From 6e0416f0e16cd19dfd0a06b9a6923f82a798467d Mon Sep 17 00:00:00 2001 From: Yannick Jadoul Date: Mon, 23 Nov 2020 19:16:27 +0100 Subject: [PATCH 1/2] Add waring about FindPython's Development component when libraries don't exist (e.g. on manylinux) --- docs/compiling.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/compiling.rst b/docs/compiling.rst index f26e6cf602..27add08ab7 100644 --- a/docs/compiling.rst +++ b/docs/compiling.rst @@ -433,6 +433,14 @@ setting ``Python_ROOT_DIR`` may be the most common one (though with virtualenv/venv support, and Conda support, this tends to find the correct Python version more often than the old system did). +.. warning:: + + When the Python libraries (i.e. ``libpythonXX.a`` and ``libpythonXX.so`` + on Unix) are not available, as is the case on a manylinux image, the + ``Development`` component will not be resolved by ``FindPython``. When not + using the embedding functionality, CMake 3.18+ allows to specify + ``Development.Module`` instead of ``Development``, to resolve this issue. + .. versionadded:: 2.6 Advanced: interface library targets From 0039a77a3c787c3229684a3b05ed802be9811f59 Mon Sep 17 00:00:00 2001 From: Yannick Jadoul Date: Mon, 23 Nov 2020 20:55:11 +0100 Subject: [PATCH 2/2] Minor wording update (thanks, @henryiii!) --- docs/compiling.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index 27add08ab7..1b9de43cef 100644 --- a/docs/compiling.rst +++ b/docs/compiling.rst @@ -438,8 +438,8 @@ Python version more often than the old system did). When the Python libraries (i.e. ``libpythonXX.a`` and ``libpythonXX.so`` on Unix) are not available, as is the case on a manylinux image, the ``Development`` component will not be resolved by ``FindPython``. When not - using the embedding functionality, CMake 3.18+ allows to specify - ``Development.Module`` instead of ``Development``, to resolve this issue. + using the embedding functionality, CMake 3.18+ allows you to specify + ``Development.Module`` instead of ``Development`` to resolve this issue. .. versionadded:: 2.6