Added support for exposing classes with private destructors and corresponding documentation#368
Merged
wjakob merged 1 commit intopybind:masterfrom Aug 27, 2016
nbelakovski:master
Merged
Added support for exposing classes with private destructors and corresponding documentation#368wjakob merged 1 commit intopybind:masterfrom nbelakovski:master
wjakob merged 1 commit intopybind:masterfrom
nbelakovski:master
Conversation
include/pybind11/common.h
Outdated
| template <typename T> | ||
| struct blank_deleter | ||
| { | ||
| void operator()(T * inst) {} |
Member
There was a problem hiding this comment.
You may want to change this to
void operator()(T*) {}to avoid unused variable warning.
…sponding documentation
Member
|
I committed a few modifications to this (renaming |
Contributor
Author
|
Yup, it works. Good call on changing to a function template. |
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Sep 4, 2016
Currently pybind11 only supports std::unique_ptr<T> holders by default (other holders can, of course, be declared using the macro). PR pybind#368 added a `py::nodelete` that is intended to be used as: py::class_<Type, std::unique_ptr<Type, py::nodelete>> c("Type"); but this doesn't work out of the box. (You could add an explicit holder type declaration, but this doesn't appear to have been the intention of the commit). This commit fixes it by generalizing the unique_ptr type_caster to take both the type and deleter as template arguments, so that *any* unique_ptr instances are now automatically handled by pybind. It also adds a test to test_smart_ptr, testing both that py::nodelete (now) works, and that the object is indeed not deleted as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in reference to issue #114.