-
Notifications
You must be signed in to change notification settings - Fork 24
Remove shlex.quote to fix issues when filenames have spaces #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm noting that this repo has not had any commits for two years and any real activity since 2024. I'd be happy to help keep this up-to-date and maintained. |
|
Looks like there's an issue in the tests? |
|
Oh, I don't think it's from this PR, though. Also seeing it in #37. |
@henryiii I was able to reproduce on Ubuntu. There, everything was solved by installing I found this by running the which gave a long error message, in which was included Not sure if this is what is going on in MacOS or not. |
adds an extra quote so files look like "'my file with spaces.h'" rather than simply "my file with spaces.h". Removing the shlex lines fixes that issue.
139d896 to
9df80d9
Compare
|
#32 looks interesting as an alternative (I just limited clang for now, probably should instead manually sync it with the runner?), but libclang seems to be stuck (18 on PyPI, 19 in repo, when llvm is past 20 now) As for maintenance, if you'd like to, please go ahead and make PRs, I can merge stuff if bumped occasionally. If you help for a while, I can bring up adding you to the pybind11 maintainers eventually. |
Awesome, sounds good. Thanks you! I'm not tied to becoming a maintainer, just figured I'd volunteer (I make use of this project a lot, and would rather spend time helping maintain than see it get lost). However, if you're already monitoring PRs and issues, that works for me :) Thanks for all the hard work keeping this going! |
|
I don't use this, I'm not monitoring issues, and we don't have a maintainer for it, so go ahead. :) As long as you add tests, I can merge stuff for now. I did a little modernization, should be mostly done now. Didn't completely follow https://learn.scientific-python.org/development/guides, but updated the biggest things I think. |
shlex.quoteadds an extra quote so files look like'my file with spaces.h'rather than simplymy file with spaces.h. Removing the shlex.quote fixes this issue.I'm not sure if these were needed in a previous version of the Python
clangpacakge, but they don't seem to be needed now.