Skip to content

Conversation

@leakec
Copy link
Contributor

@leakec leakec commented Nov 12, 2025

shlex.quote adds an extra quote so files look like 'my file with spaces.h' rather than simply my file with spaces.h. Removing the shlex.quote fixes this issue.

I'm not sure if these were needed in a previous version of the Python clang pacakge, but they don't seem to be needed now.

@leakec
Copy link
Contributor Author

leakec commented Nov 12, 2025

I'm noting that this repo has not had any commits for two years and any real activity since 2024. I'd be happy to help keep this up-to-date and maintained.

@henryiii
Copy link
Collaborator

Looks like there's an issue in the tests?

@henryiii
Copy link
Collaborator

Oh, I don't think it's from this PR, though. Also seeing it in #37.

@leakec
Copy link
Contributor Author

leakec commented Nov 12, 2025

Oh, I don't think it's from this PR, though. Also seeing it in #37.

@henryiii I was able to reproduce on Ubuntu. There, everything was solved by installing clang==18.1.8 rather than the newest clang. Ubuntu 24.04 has llvm 18 installed by apt, so choosing the same version in Python matches the library.

I found this by running the pybind11 command manually, i.e.,

pybind11-mkdoc -o . sample_header_docs/sample_header.h

which gave a long error message, in which was included

AttributeError: /usr/lib/llvm-18/lib/libclang.so.1: undefined symbol: clang_getOffsetOfBase

Not sure if this is what is going on in MacOS or not.

adds an extra quote so files look like "'my file with spaces.h'" rather
than simply "my file with spaces.h". Removing the shlex lines fixes that issue.
@henryiii
Copy link
Collaborator

#32 looks interesting as an alternative (I just limited clang for now, probably should instead manually sync it with the runner?), but libclang seems to be stuck (18 on PyPI, 19 in repo, when llvm is past 20 now)

As for maintenance, if you'd like to, please go ahead and make PRs, I can merge stuff if bumped occasionally. If you help for a while, I can bring up adding you to the pybind11 maintainers eventually.

@henryiii henryiii merged commit 5af54d9 into pybind:master Nov 12, 2025
7 checks passed
@leakec
Copy link
Contributor Author

leakec commented Nov 12, 2025

#32 looks interesting as an alternative (I just limited clang for now, probably should instead manually sync it with the runner?), but libclang seems to be stuck (18 on PyPI, 19 in repo, when llvm is past 20 now)

As for maintenance, if you'd like to, please go ahead and make PRs, I can merge stuff if bumped occasionally. If you help for a while, I can bring up adding you to the pybind11 maintainers eventually.

Awesome, sounds good. Thanks you!

I'm not tied to becoming a maintainer, just figured I'd volunteer (I make use of this project a lot, and would rather spend time helping maintain than see it get lost). However, if you're already monitoring PRs and issues, that works for me :)

Thanks for all the hard work keeping this going!

@henryiii
Copy link
Collaborator

I don't use this, I'm not monitoring issues, and we don't have a maintainer for it, so go ahead. :) As long as you add tests, I can merge stuff for now. I did a little modernization, should be mostly done now. Didn't completely follow https://learn.scientific-python.org/development/guides, but updated the biggest things I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants