Suggest sorting of extension sources to ensure a reproducible build #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egardless of filesystem ordering. re. pikepdf/pikepdf#76
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
|
LGTM, thanks! |
|
I amended the commit to add an explanation for why the sort() command is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR suggests the sorting of extension sources to ensure a reproducible build regardless of the layout on the file system. For example, in my PR to pikepdf:
… otherwise the sources were iterated and linked in a nondeterminstic order and thus the build was not bit-for-bit identical on subsequent build runs.