New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Github activity from forked repos #2

Closed
jmtaysom opened this Issue Mar 13, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@jmtaysom
Contributor

jmtaysom commented Mar 13, 2017

While forking the repo and cloning from everyones own repository is easy it makes it so that when you work on a solution you dont get credit for github activity since it is in a forked repo. See https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/

What I did when I realized I wasnt getting credit for the activity is delete the fork on github, create a new repo on github, pushed it up to my and then set the upstream to the original repo so I could still pull updates. It is definitely not as easy but if people are using these challenges to acomplish things like 100 days of code they may want to see their progress show up on their activity board.

@bbelderbos

This comment has been minimized.

Collaborator

bbelderbos commented Mar 13, 2017

Actually that is a really good point, thanks for brining that up.

We were looking at PR but it seems you have to merge a whole branch. It was not straight-forward for our use case, but I'll also admit I have not used the feature a lot yet.

How could we do it in a clean (non-merge-conflicting) way so that somebody can just merge a challenge-name.py solution file?

Could we use git cherry-pick for example?
http://stackoverflow.com/questions/5256021/send-a-pull-request-on-github-for-only-latest-commit

Happy to hear your thoughts ...

Cheers
Bob

@jmtaysom

This comment has been minimized.

Contributor

jmtaysom commented Mar 13, 2017

The one problem I see with letting pull requests is that say 10 people solve a challenge, now when I make my next pull from upstream I am going to get all of their work too. Maybe you could set it up so each person can have their own branch that never gets merged into master. That way master stays clean with no solutions in it but people could easily explore the branches and even pull the branches if there were interested in exploring something themselves. It would necessarily be git novice friendly though.

@bbelderbos

This comment has been minimized.

Collaborator

bbelderbos commented Mar 14, 2017

Hey Jim, cool, we already use a separate solutions branch for PyBites solutions, keeping master 'clean'.

I made a new 'community' branch:
https://github.com/pybites/challenges/branches

I was able to do a PR
direction : user : repo : branch
from : bbelderbos : challenges(fork) : community
into : pybites : challenges : commity
(see #3)

Requirements

  • git pull/merge new community branch and use it for your solution
  • name your solution template-GHuser.py (e.g. hangman-bbelderbos.py) to not conflict when more users start doing this.

The PR is under my (bbelderbos) Contribution activity, that's the goal right?

Can you give it a try?
Does it work? And is it a good approach?

If so I will update the INSTALL doc

Thanks again for raising this:

  • allowing submissions will make this more interesting
  • good learning on how GH PRs work
@jmtaysom

This comment has been minimized.

Contributor

jmtaysom commented Mar 14, 2017

@jmtaysom

This comment has been minimized.

Contributor

jmtaysom commented Mar 14, 2017

@jmtaysom

This comment has been minimized.

Contributor

jmtaysom commented Mar 14, 2017

@bbelderbos

This comment has been minimized.

Collaborator

bbelderbos commented Mar 15, 2017

Hi Jim, thanks for the link. Seems we can still benefit from working with PRs. And not merging won't cause a mess. Would this work for you regarding getting credit on your GH profile?

@jmtaysom

This comment has been minimized.

Contributor

jmtaysom commented Mar 15, 2017

@bbelderbos

This comment has been minimized.

Collaborator

bbelderbos commented Mar 15, 2017

Hi Jim, yes please do so, then I will link to it in the INSTALL. At least we clarify / set expectations. I also think the non-accept PR thing can be interesting in order to get solutions into our community branch (even if we have to do some manual work). Thanks.

@pybites

This comment has been minimized.

Owner

pybites commented Mar 18, 2017

Thanks for the PR / doc update Jim

@pybites pybites closed this Mar 18, 2017

nirentuladhar added a commit to nirentuladhar/challenges that referenced this issue Jan 14, 2018

goitom pushed a commit to goitom/challenges that referenced this issue Oct 2, 2018

nharbison added a commit to nharbison/challenges that referenced this issue Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment