New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC04 code-monk08 #406

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@code-monk08

code-monk08 commented Oct 30, 2018

ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!

Difficulty level (1-10): [5]
Estimated time spent (hours): [2, 2.5 for finding a silly error :| but I was so satisfied after everything was working]
Completed (yes/no): [yes 馃憤 ]
I stretched my coding skills (if yes what did you learn?): [I finally worked with an API in python, I found little more information about working of unittests, got to know little more about CSV module. ]
Other feedback (what can we improve?): [all great 馃挴 ]

@pybites

This comment has been minimized.

Owner

pybites commented Nov 9, 2018

Good learning

def read_csv(fname):
with open(fname) as f:
has_header = csv.Sniffer().has_header(f.readline())

This comment has been minimized.

@pybites

pybites Nov 9, 2018

Owner

cool didn't know about Sniffer, I usually use DictReader

@pybites pybites merged commit c73c389 into pybites:community Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment