day 3 challenge #782
Merged
day 3 challenge #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
approved these changes
Dec 12, 2020
|
|
||
| def main(): | ||
| pomodoro_count = 0 | ||
| while True: |
Collaborator
There was a problem hiding this comment.
Is there anything that would break out of this loop?
| from datetime import timedelta | ||
|
|
||
| def timer(timer_type): | ||
| if timer_type == "pomodoro": |
Collaborator
There was a problem hiding this comment.
the only difference here are the number of minutes, so you could turn this into a dictionary: timer_times = {'pomodoro': 25, 'short_break': 5, 'long_break': 10}, then you don't have to repeat endtime = datetime.now() + timedelta(minutes=<int>) 3 times
|
|
||
| while (datetime.now().replace(microsecond=0) != endtime.replace(microsecond=0)): | ||
| timeleft = endtime - datetime.now() | ||
| timeleft = str(timeleft).split(".")[0] |
Collaborator
There was a problem hiding this comment.
Or:
>>> timeleft
datetime.timedelta(seconds=9, microseconds=687388)
>>> timeleft.seconds
9
| while (datetime.now().replace(microsecond=0) != endtime.replace(microsecond=0)): | ||
| timeleft = endtime - datetime.now() | ||
| timeleft = str(timeleft).split(".")[0] | ||
| print(f"{timeleft}", end='\r') |
Collaborator
There was a problem hiding this comment.
Is \r something you had to do for Windows?
| @@ -0,0 +1,46 @@ | |||
| import time | |||
| from datetime import datetime | |||
| from datetime import timedelta | |||
Collaborator
There was a problem hiding this comment.
Can do in one import: from datetime import datetime, timedelta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): 4
Estimated time spent (hours): <1
Completed (yes/no): yes
I stretched my coding skills (if yes what did you learn?): more practice with lists and datetime
Other feedback (what can we improve?): []