PCC16 covrebo #794
Merged
PCC16 covrebo #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
approved these changes
Feb 17, 2021
| @app.route('/') | ||
| def hello_world(): | ||
| # get dad joke | ||
| joke = services.get_dad_joke() |
Collaborator
There was a problem hiding this comment.
Nice you added a service layer.
| @@ -0,0 +1,2 @@ | |||
| # CanHazDadJoke | |||
| A single page [flask](https://flask.palletsprojects.com/en/1.1.x/) app that presents a button to press for a dad joke. A dad joke is received from the [icanhazdadjoke](https://icanhazdadjoke.com/) API as `json`. The `json` is then parsed and presented in a modal to the user. Page is styled using [Bootstrap](https://getbootstrap.com/) v5.0. A more detailed description of the project can be found [here](https://covrebo.com/retrieving-json-with-flask.html). No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Cool idea, didn't know about that API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): [8]
Estimated time spent (hours): [6]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): [Yes, I had not worked with JSON or API's before so it was all new to me.]
Other feedback (what can we improve?): [This is a great challenge with lots of freedom to express creativity!]