Pcc45 #844
Merged
Pcc45 #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
reviewed
Sep 26, 2022
|
|
||
| def test_fizzbuzz_returns_fizz_with_multiples_of_3(self): | ||
| samples = [3, 6, 9, 12] | ||
| for sample in samples: |
Collaborator
There was a problem hiding this comment.
You can use paremetrize: https://docs.pytest.org/en/6.2.x/parametrize.html
| result = fizzbuzz(sample) | ||
| self.assertEqual(result, "FizzBuzz") | ||
|
|
||
| def test_fizzbuzz_raises_error_message_if_arg_not_int(self): |
Collaborator
There was a problem hiding this comment.
nice descriptive name, I don't mind test function names to be longer
| """ | ||
| FizzBuzz(int) plays FizzBuzz | ||
| """ | ||
| if not isinstance(num, int): |
Collaborator
There was a problem hiding this comment.
mypy would also catch this, but it does not prevent the function from being used by other types, after a raise you don't need the else so you could dedent the code below one level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): [2]
Estimated time spent (hours): [1]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): [learned some TDD]
Other feedback (what can we improve?): []