-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow injecting tasks as dependents #188
Comments
@mriehl review please |
Neat idea, bear with me for a few hours. I'll review today. |
I'd change the name though, I think |
I was thinking of it as: @task
@depends("task_a", optional("task_b"))
@dependent("task_c", optional("task_d"))
def new_plugin_task():
pass I.e. create |
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
arcivanov
added a commit
to arcivanov/pybuilder
that referenced
this issue
Nov 20, 2015
fixes pybuilder#188, connected to pybuilder#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when you add a
@task
you're limited in flexibility in where you can add it.Unless the new task follows core plugin graph and extends a particular existing task or is invoked as a top-level task, there is no way to do this:
This would allow 3rd party plugins to augment the build graph (such as header check plugin) without the user having to add top-level tasks. I.e.
pyb publish
with an injection of a header check plugin will result in a header check plugin executing a task without having to specifypyb check_headers publish
.All circularity/resolution check enforcements should, naturally, stay in force.
A new construct such as
@dependent("task_a", "task_b", optional("task_c", "task_d"))
will be introduced.The text was updated successfully, but these errors were encountered: