New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PyB projects to be installed via URL-based install #200

Closed
arcivanov opened this Issue Sep 20, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@arcivanov
Contributor

arcivanov commented Sep 20, 2015

Currently PyB allows itself to be installed via pip install <url> by means of a setup file. Unfortunately other projects using PyB cannot take advantage of this without copying the file.

Therefore,

  • See if setup.py can be cleaned up and/or simplified. Simplified in #269
  • Add a task into the core that (re-)generates setup.py file to provide URL-based install to any project.

@arcivanov arcivanov changed the title from Allow PyB projects to be installed via `pip install <archive/CVS url>` to Allow PyB projects to be installed via URL-based install Sep 20, 2015

@arcivanov arcivanov self-assigned this Sep 20, 2015

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Sep 20, 2015

Member

Good points. Maybe we can integrate this with the scaffolding module (pyb --start-project). Kinda like when starting a scala project you get the option of embedding a SBT launcher, also very much like the gradle wrapper which is created by idea when you set up a gradle project.

Member

mriehl commented Sep 20, 2015

Good points. Maybe we can integrate this with the scaffolding module (pyb --start-project). Kinda like when starting a scala project you get the option of embedding a SBT launcher, also very much like the gradle wrapper which is created by idea when you set up a gradle project.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Sep 20, 2015

Contributor

Yep, --start-project seems like a reasonable place for this. But we also need to allow regenerating of the file if we have to refresh it. Can --start-project be rerun idempotently without breaking what's already there?

Contributor

arcivanov commented Sep 20, 2015

Yep, --start-project seems like a reasonable place for this. But we also need to allow regenerating of the file if we have to refresh it. Can --start-project be rerun idempotently without breaking what's already there?

@arcivanov arcivanov modified the milestone: v0.11.2 Sep 23, 2015

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Sep 23, 2015

Member

No, it's pretty basic templating. We would have to go through the AST somehow in order to regenerate, but even then it's not easy because project.set_property() does not look like getattr(project, "set_property")() in the AST but it's actually the same thing. So it would be really hard to not re-add things that are already there.

Maybe we can have both: a task that (re)generates the setup.py and --start-project simply calls this when it's done.

Member

mriehl commented Sep 23, 2015

No, it's pretty basic templating. We would have to go through the AST somehow in order to regenerate, but even then it's not easy because project.set_property() does not look like getattr(project, "set_property")() in the AST but it's actually the same thing. So it would be really hard to not re-add things that are already there.

Maybe we can have both: a task that (re)generates the setup.py and --start-project simply calls this when it's done.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Sep 23, 2015

Contributor

Yeah, I'm for the latter approach I think.

Contributor

arcivanov commented Sep 23, 2015

Yeah, I'm for the latter approach I think.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Nov 20, 2015

Contributor

depends on #263

Contributor

arcivanov commented Nov 20, 2015

depends on #263

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Nov 24, 2015

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Nov 27, 2015

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Nov 28, 2015

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Nov 28, 2015

@arcivanov arcivanov closed this in #273 Nov 28, 2015

@arcivanov arcivanov removed the in progress label Nov 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment