-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake8 script file filter properties misbehave #202
Comments
Yes the Maybe a regexp would be okay (default to |
The problem seems simpler than that: I appended ",hcsos*" to the exclusion list and it didn't exclude, i.e. there is something wrong with how we manipulate exclusions. |
Yeah, well, that's not Flake8, it's PyB outsmarting itself... Flake8 can process either directories or files. When directories are passed, you can @mriehl should we continue passing files to Flake8 and handle the patterns ourselves or should we just pass source directories along with uninterpreted patterns? Example of behavior:
|
For now I'll submit a PR to fix this by delegating filtering responsibility fully to flake8 and introducing "include" pattern into options. |
👍 for letting flake8 decide |
fixes pybuilder#202, connected to pybuilder#202
fixes pybuilder#202, connected to pybuilder#202
Flake8 script file filter properties misbehave #202
Tried excluding bash files without
.sh
extensions from testing for flake8 by appending to a property, but was unsuccessful, had to disable flake8 on scripts entirely.Looks like a bug, need to investigate.
The text was updated successfully, but these errors were encountered: