Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% coverage is not 100% #203

Closed
Tracked by #199
arcivanov opened this issue Sep 20, 2015 · 0 comments · Fixed by #207
Closed
Tracked by #199

100% coverage is not 100% #203

arcivanov opened this issue Sep 20, 2015 · 0 comments · Fixed by #207
Assignees
@arcivanov
Labels
bug enhancement
Milestone
v0.11.2

Comments

@arcivanov
Copy link
Member

With branch coverage being introduced there is a curious case of 100% code coverage possible without 100% branch coverage.

Whenever the following code is encountered:

    if a:
       pass

it's possible to achieve 100% coverage in the unit test by setting a to True, while never testing the behaviors when a is False. This needs to be rectified, possibly by adding a property specifying a separate branch coverage threshold and enforcing it separately from and in addition to line coverage.
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Sep 21, 2015
@arcivanov
100% coverage is not 100% pybuilder#203
9b4e8d5 
fixes pybuilder#203, connected to pybuilder#203
@arcivanov arcivanov mentioned this issue Sep 21, 2015
Merged
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Sep 23, 2015
@arcivanov
100% coverage is not 100% pybuilder#203
aa8fb99 
fixes pybuilder#203, connected to pybuilder#203
@arcivanov arcivanov modified the milestone: v0.11.2 Sep 23, 2015
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Sep 23, 2015
@arcivanov
100% coverage is not 100% pybuilder#203
c09a989 
fixes pybuilder#203, connected to pybuilder#203
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Sep 24, 2015
@arcivanov
100% coverage is not 100% pybuilder#203
c43d118 
fixes pybuilder#203, connected to pybuilder#203
arcivanov added a commit that referenced this issue Sep 24, 2015
@arcivanov
Merge pull request #207 from arcivanov/issue_203
25516c4 
100% coverage is not 100% #203
@arcivanov arcivanov mentioned this issue Sep 24, 2015
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcivanov arcivanov

Labels
bug enhancement
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging a pull request may close this issue.

100% coverage is not 100% #203 arcivanov/pybuilder
1 participant
@arcivanov