New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pip --trusted-host argument #341

Closed
JoshBroadway opened this Issue Mar 11, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@JoshBroadway

JoshBroadway commented Mar 11, 2016

Hi,

I'm trying to setup PyBuilder to download pip dependencies from a localshop instance that I've setup and I'm getting the error:
The repository located at <IP_ADDR> is not a trusted or secure host and is being ignored.

On the pip command line, I'm able to install my dependencies by adding --trusted-host = <IP_ADDR> to my command.

I've searched through the pip_utils.py source code and cannot find any reference to --trusted_host. Is there currently any support for the '--trusted_host' flag in PyBuilder? If not, are there any plans to add it?

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 11, 2016

Contributor

I'll take care of this, thanks for the report.

Contributor

arcivanov commented Mar 11, 2016

I'll take care of this, thanks for the report.

@arcivanov arcivanov self-assigned this Mar 11, 2016

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Mar 22, 2016

Support for pip --trusted-host argument enhancement
This also changes the following behaviors:
* extra-index-url is now supported without specifying index-url
* trusted-host and extra-index-url can specify both a single value and a collection as pip allows that

trusted-host added for both dependency and plugin installs

fixes #341, connected to #341
@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 22, 2016

Contributor

@BackroomGibbon please try out this change using

pip install --upgrade git+git://github.com/arcivanov/pybuilder@issue_341

Contributor

arcivanov commented Mar 22, 2016

@BackroomGibbon please try out this change using

pip install --upgrade git+git://github.com/arcivanov/pybuilder@issue_341

@JoshBroadway

This comment has been minimized.

Show comment
Hide comment
@JoshBroadway

JoshBroadway Mar 23, 2016

Hi @arcivanov ,

I've just tested this locally and I can confirm that the new install_dependencies_trusted_host property works.

Thanks for this!

When do you plan to release the next release containing this enhancement?

JoshBroadway commented Mar 23, 2016

Hi @arcivanov ,

I've just tested this locally and I can confirm that the new install_dependencies_trusted_host property works.

Thanks for this!

When do you plan to release the next release containing this enhancement?

@mriehl mriehl closed this in #345 Mar 23, 2016

@arcivanov arcivanov removed the in progress label Mar 23, 2016

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Mar 23, 2016

Member

Reopening as not released

Member

mriehl commented Mar 23, 2016

Reopening as not released

@mriehl mriehl reopened this Mar 23, 2016

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Mar 23, 2016

Member

We can release this ASAP if you want. @arcivanov @esc any objections to a release today?

Member

mriehl commented Mar 23, 2016

We can release this ASAP if you want. @arcivanov @esc any objections to a release today?

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Mar 23, 2016

Member

@BackroomGibbon you can also install the newest dev release if you want. Should be built and uploaded automatically in a few. You can get the dev version with the --pre flag in pip upgrade.

Member

mriehl commented Mar 23, 2016

@BackroomGibbon you can also install the newest dev release if you want. Should be built and uploaded automatically in a few. You can get the dev version with the --pre flag in pip upgrade.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 23, 2016

Contributor

@mriehl no objections

Contributor

arcivanov commented Mar 23, 2016

@mriehl no objections

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Mar 24, 2016

Member

@BackroomGibbon released with 0.11.8.

Member

mriehl commented Mar 24, 2016

@BackroomGibbon released with 0.11.8.

@mriehl mriehl closed this Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment