Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.distutils plugin: setup.py keywords #422

Closed
timdiels opened this issue Nov 22, 2016 · 5 comments · Fixed by #424
Closed

python.distutils plugin: setup.py keywords #422

timdiels opened this issue Nov 22, 2016 · 5 comments · Fixed by #424

Comments

@timdiels
Copy link

I'd like to request support for setup.py keywords in the python.distutils plugin

For example (tersely):

  • build.py: project.set_property('distutils_keywords', 'keyword1 key-word2').
  • outputted setup.py: setup(keywords='keyword1 key-word2', ...). Defaults to keywords='' or omit the argument entirely if distutils_keywords was not set.

PS: great project, may its user base grow plentiful.

@arcivanov
Copy link
Member

This is already supported. According to setuptools this is how you do it:
http://setuptools.readthedocs.io/en/latest/setuptools.html#adding-setup-arguments
Flexible entry points are already a feature:
https://github.com/pybuilder/pybuilder/blob/master/src/unittest/python/plugins/python/distutils_plugin_tests.py#L537

@timdiels
Copy link
Author

It appears this only allows validating arguments given to the setup.py script. Could you give me an example of setting the keywords this way? Thanks in advance.

@arcivanov
Copy link
Member

Ah, I got what you want to do.

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Nov 23, 2016
@arcivanov
Copy link
Member

@timdiels should be all set

@timdiels
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants