Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting $dir_dist will cause generated setup.py to fail. #657

Closed
arcivanov opened this issue Mar 3, 2020 · 3 comments · Fixed by #681
Closed

Overwriting $dir_dist will cause generated setup.py to fail. #657

arcivanov opened this issue Mar 3, 2020 · 3 comments · Fixed by #681
Assignees
Labels

Comments

@arcivanov
Copy link
Member

related #508

@arcivanov arcivanov self-assigned this Mar 3, 2020
@arcivanov
Copy link
Member Author

@margru for reference

@arcivanov arcivanov added the bug label Mar 7, 2020
@arcivanov
Copy link
Member Author

@margru question for you, what pip version are you running?

arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 5, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
arcivanov added a commit to arcivanov/pybuilder that referenced this issue Apr 6, 2020
Distutils Plugin now:
1) Allows skip-existing version on Twine
2) Performs a Twine check for PyPi compatibility
pyproject.toml and generated setup.py properly handle overwritten `$dir_dist`

fixes pybuilder#657, pybuilder#508
@margru
Copy link

margru commented Apr 6, 2020

@margru question for you, what pip version are you running?

@arcivanov I am not sure if I remember it but I think it actually didn't matter. In one project it was like 10, in another one like 20. However, I can see that you were able to solve it even without that information. Looking forward to give it a try once it is released.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants