-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide proper colors in Windows #660
Comments
This is a great idea but requires a different implementation from what is proposed. |
Could you please explain what you have in mind? This is the only thing that actually worked on my Windows station. |
PyBuilder can't really have dependencies, i.e. it has to be able to install without affecting anything in its environment. I'll need to look at getting colorama vendored. |
Indeed, I was also thinking along these lines (that's why I put it in a try/except statement). Then if colorama is installed in the environment it will be used, and otherwise not. It'd be nice to have it included under windows. I'm missing the colors :-). |
Let me see if I can get it for 0.12.0. I'll need to read colorama to see how it does what it does and whether there will be side effects. |
Update VirtualEnv Add Colorama on Windows when stdout is a TTY fixes pybuilder#660
Hello,
I was playing a bit around with the colored (and not so colored) output of pybuilder because this is what I'm seeing (just a small test):
The only thing I could make it work with was colorama. They have a very good Windows implementation.
How do you feel like I integrate this into pybuilder? I know it's a dependency of pybuilder, but I couldn't make the escape sequences work in python 3.7.6 at all on my windows console (even though when I type them manually in they work fine!).
Just let me know,
Steven
The text was updated successfully, but these errors were encountered: