Skip to content

ExternalCommandBuilder not backwards compatible #692

@soda480

Description

@soda480

The latest version of pybuilder 0.12.0 requires a new positional argument for ExternalCommandBuilder which causes all of our existing builds to fail with TypeError: __init__() missing 1 required positional argument: 'reactor':

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/pybuilder/cli.py", line 468, in main
    environments=options.environments, tasks=arguments)
  File "/usr/local/lib/python3.6/site-packages/pybuilder/reactor.py", line 235, in build
    execution_summary = self.build_execution_plan(tasks, execution_plan)
  File "/usr/local/lib/python3.6/site-packages/pybuilder/reactor.py", line 274, in build_execution_plan
    reactor=self)
  File "/usr/local/lib/python3.6/site-packages/pybuilder/execution.py", line 399, in execute_execution_plan
    summaries.append(self.execute_task(task, **kwargs))
  File "/usr/local/lib/python3.6/site-packages/pybuilder/execution.py", line 346, in execute_task
    task.execute(self.logger, kwargs, _executable=_executable)
  File "/usr/local/lib/python3.6/site-packages/pybuilder/execution.py", line 187, in execute
    executable.execute(argument_dict)
  File "/usr/local/lib/python3.6/site-packages/pybuilder/execution.py", line 101, in execute
    self.callable(*arguments)
  File "./build.py", line 52, in cyclomatic_complexity
    command = ExternalCommandBuilder('radon', project)
TypeError: __init__() missing 1 required positional argument: 'reactor'

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions