Dereference directory symlink in src/main/python/ #768

Activity

1. hoxu commented on Feb 11, 2021

   

   hoxu

   on Feb 11, 2021

   ContributorAuthor

   More actions

   Further digging revealed that symlinked directories are dereferenced properly, and copied to target/dist/$name/.

   However, setup.py -v clean --all bdist_wheel does not include the copied files in the tarball, because they are not included in packages or py_modules.

   This appears to be a bug in pybuilder: it seems to dereference directory symlinks when copying the files, but not when generating packages/py_modules.

   Relevant source code is probably pybuilder.plugins.python.core_plugin.{list_packages,list_modules}:

   pybuilder/src/main/python/pybuilder/plugins/python/core_plugin.py

   Lines 106 to 124 in 6ac1ef4

   	def list_packages(project):
   	source_path = project.expand_path("$" + PYTHON_SOURCES_PROPERTY)
   	result = []
   	for root, dirs, files in walk(source_path):
   	if "__init__.py" in files:
   	result.append(relpath(root, source_path).replace(sep, "."))
   	return sorted(result)
   	def list_modules(project):
   	source_path = project.expand_path("$" + PYTHON_SOURCES_PROPERTY)
   	result = []
   	for potential_module_file in listdir(source_path):
   	potential_module_path = np(jp(source_path, potential_module_file))
   	if isfile(potential_module_path) and potential_module_file.endswith(".py"):
   	result.append(potential_module_file[:-3])
   	return sorted(result)

   os.walk defaults to followlinks=False.
2. arcivanov

   added 7 commits that reference this issue on Sep 12, 2021

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 5203aec is merged into the 'master' branch.

   5203aec

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 9c4113b is merged into the 'master' branch.

   9c4113b

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 3bd7b18 is merged into the 'master' branch.

   3bd7b18

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 83eaef4 is merged into the 'master' branch.

   83eaef4

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 80885d1 is merged into the 'master' branch.

   80885d1

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit b14e842 is merged into the 'master' branch.

   b14e842

   Rework list_modules, list_packages and list_scripts

   ...

   This issue will close once commit 618512b is merged into the 'master' branch.

   618512b
3. arcivanov

   closed this as completedin #786on Sep 12, 2021