New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_dependencies_(extra_)index_url should affect all PIP operations #313

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Projects
None yet
3 participants
@arcivanov
Contributor

arcivanov commented Jan 12, 2016

fixes #312, connected to #312

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Jan 12, 2016

Contributor

@mriehl review please?

Contributor

arcivanov commented Jan 12, 2016

@mriehl review please?

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Jan 12, 2016

Contributor

@snordhausen does this fix your problem?

Contributor

arcivanov commented Jan 12, 2016

@snordhausen does this fix your problem?

@snordhausen

This comment has been minimized.

Show comment
Hide comment
@snordhausen

snordhausen Jan 12, 2016

My build works fine with that fix. Thanks!

snordhausen commented Jan 12, 2016

My build works fine with that fix. Thanks!

arcivanov added a commit that referenced this pull request Jan 12, 2016

Merge pull request #313 from arcivanov/issue_312
install_dependencies_(extra_)index_url should affect all PIP operations

@arcivanov arcivanov merged commit 051e621 into pybuilder:master Jan 12, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 71.834%
Details

@arcivanov arcivanov deleted the arcivanov:issue_312 branch Jan 12, 2016

@arcivanov arcivanov removed the in progress label Jan 12, 2016

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jan 15, 2016

Member

Thanks @arcivanov for fixing and @snordhausen for confirming that it works. I will cut a release today so that it works without installing a development version.

Member

mriehl commented Jan 15, 2016

Thanks @arcivanov for fixing and @snordhausen for confirming that it works. I will cut a release today so that it works without installing a development version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment