Update cram plugin to use the 'outside' environment #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not culpable for the appveyor tests failing. |
|
Yeah they're not green currently. I have in my backlog somewhere to only have them trigger on the windows branch, I'm pulling it up. |
|
@karolyi could you squash? I'll merge afterwards. Looks good. |
karolyi
changed the title
mriehl
added a commit
that referenced
this pull request
Jan 25, 2016
Update cram plugin to use the 'outside' environment
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification instructs
cramto use the 'outside' environment variables, without which commands with UTF-8 encoded characters get encoded with their surrogate-escape counterparts, resulting in automated tests failing.For details, see aiiie/cram#7.
Until this pull request is not merged,
afp-cliwon't build.