New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cram plugin to use the 'outside' environment #316

Merged
merged 1 commit into from Jan 25, 2016

Conversation

Projects
None yet
3 participants
@karolyi
Contributor

karolyi commented Jan 25, 2016

This modification instructs cram to use the 'outside' environment variables, without which commands with UTF-8 encoded characters get encoded with their surrogate-escape counterparts, resulting in automated tests failing.

For details, see brodie/cram#7.

Until this pull request is not merged, afp-cli won't build.

@karolyi

This comment has been minimized.

Show comment
Hide comment
@karolyi

karolyi Jan 25, 2016

Contributor

I'm not culpable for the appveyor tests failing.

Contributor

karolyi commented Jan 25, 2016

I'm not culpable for the appveyor tests failing.

@mriehl mriehl self-assigned this Jan 25, 2016

@mriehl mriehl added the in progress label Jan 25, 2016

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jan 25, 2016

Member

Yeah they're not green currently. I have in my backlog somewhere to only have them trigger on the windows branch, I'm pulling it up.

Member

mriehl commented Jan 25, 2016

Yeah they're not green currently. I have in my backlog somewhere to only have them trigger on the windows branch, I'm pulling it up.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jan 25, 2016

Member

@karolyi could you squash? I'll merge afterwards. Looks good.

Member

mriehl commented Jan 25, 2016

@karolyi could you squash? I'll merge afterwards. Looks good.

@karolyi karolyi changed the title from Update cram plugin to use 'outside' environment to Update cram plugin to use the 'outside' environment Jan 25, 2016

mriehl added a commit that referenced this pull request Jan 25, 2016

Merge pull request #316 from karolyi/master
Update cram plugin to use the 'outside' environment

@mriehl mriehl merged commit 142fa17 into pybuilder:master Jan 25, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.0%) to 71.942%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arcivanov arcivanov removed the in progress label Jan 25, 2016

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jan 25, 2016

Member

Released with v0.11.5

Member

mriehl commented Jan 25, 2016

Released with v0.11.5

@karolyi karolyi referenced this pull request Jan 25, 2016

Merged

Issue fix #42 & #43 #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment