New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the flag for cram to run tests from the target directory #318

Merged
merged 3 commits into from Jan 29, 2016

Conversation

Projects
None yet
3 participants
@karolyi
Contributor

karolyi commented Jan 28, 2016

karolyi added some commits Jan 28, 2016

Adding the flag for cram to run tests from the target directory
- with the option 'cram_run_test_from_target' to True (default is False)
  cram tests will be executed using the built artifact to be found in
  the target directory
- this way, filtered scripts
  (http://pybuilder.github.io/documentation/plugins.html#Filteringfiles)
  which contain needed information for the tests, can be used.

karolyi added a commit to ImmobilienScout24/afp-cli that referenced this pull request Jan 28, 2016

resolves #33, add automatic versioning by pybuilder
- In order for this commit to go through, a pull request involving
  pybuilder cram plugin update needs to be merged:
  pybuilder/pybuilder#318
@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 28, 2016

Member

I (the author of the cram plugin) collaborated on this. We chose to keep running cram from src by default since this makes it backwards compatible. We feel however that running cram from target would be the better alternative but were unsure, which task to depend on. We tried making target the default but this seemed to cause problems.

Member

esc commented Jan 28, 2016

I (the author of the cram plugin) collaborated on this. We chose to keep running cram from src by default since this makes it backwards compatible. We feel however that running cram from target would be the better alternative but were unsure, which task to depend on. We tried making target the default but this seemed to cause problems.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 28, 2016

Member

Also, the appveyor stuff isn't our doing.

Member

esc commented Jan 28, 2016

Also, the appveyor stuff isn't our doing.

After fixing the path resolving problem ...
... cram_run_test_from_target can be set True per default
@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jan 28, 2016

Member

Yes you can ignore the appveyor for now. I have to move the hook to the windows compat branch but haven't gotten around to doinc it just yet.

Member

mriehl commented Jan 28, 2016

Yes you can ignore the appveyor for now. I have to move the hook to the windows compat branch but haven't gotten around to doinc it just yet.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 29, 2016

Member

We now set cram_run_from_target to True. Can you remind me, what is the task that puts things in the target directory? Is it package? If so, maybe we should depend on that task in the cram plugin, currently it is prepare IIRC?

Member

esc commented Jan 29, 2016

We now set cram_run_from_target to True. Can you remind me, what is the task that puts things in the target directory? Is it package? If so, maybe we should depend on that task in the cram plugin, currently it is prepare IIRC?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 29, 2016

Member

Though it seems like verify already does that, so I don't think this change will cause any breakage in existing tools.

Member

esc commented Jan 29, 2016

Though it seems like verify already does that, so I don't think this change will cause any breakage in existing tools.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 29, 2016

Member

Also, once this is merged, I will update the documentation for the cram plugin in docs.

Member

esc commented Jan 29, 2016

Also, once this is merged, I will update the documentation for the cram plugin in docs.

@karolyi

This comment has been minimized.

Show comment
Hide comment
@karolyi

karolyi Jan 29, 2016

Contributor

👍

Contributor

karolyi commented Jan 29, 2016

👍

@esc esc referenced this pull request Jan 29, 2016

Merged

update cram docs #14

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 29, 2016

Member

Allright after some internal discussion with @mriehl I'll merge this now and release a new version.

Member

esc commented Jan 29, 2016

Allright after some internal discussion with @mriehl I'll merge this now and release a new version.

esc added a commit that referenced this pull request Jan 29, 2016

Merge pull request #318 from karolyi/run_cram_from_target_possibility
Adding the flag for cram to run tests from the target directory

@esc esc merged commit 152e4ef into pybuilder:master Jan 29, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 71.959%
Details
@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jan 29, 2016

Member

done

Member

esc commented Jan 29, 2016

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment