Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the flag for cram to run tests from the target directory #318

Merged
merged 3 commits into from
Jan 29, 2016
Merged

Adding the flag for cram to run tests from the target directory #318

merged 3 commits into from
Jan 29, 2016

Conversation

karolyi
Copy link
Contributor

@karolyi karolyi commented Jan 28, 2016

@karolyi
Adding the flag for cram to run tests from the target directory
c835870 
- with the option 'cram_run_test_from_target' to True (default is False)
  cram tests will be executed using the built artifact to be found in
  the target directory
- this way, filtered scripts
  (http://pybuilder.github.io/documentation/plugins.html#Filteringfiles)
  which contain needed information for the tests, can be used.
@karolyi
Fixing the malformed script_dir_dist resolution
82408c6
karolyi added a commit to Scout24/afp-cli that referenced this pull request Jan 28, 2016
@karolyi
resolves #33, add automatic versioning by pybuilder
5904baf 
- In order for this commit to go through, a pull request involving
  pybuilder cram plugin update needs to be merged:
  pybuilder/pybuilder#318
@karolyi karolyi mentioned this pull request Jan 28, 2016
Merged
@esc
Copy link
Contributor

esc commented Jan 28, 2016

I (the author of the cram plugin) collaborated on this. We chose to keep running cram from src by default since this makes it backwards compatible. We feel however that running cram from target would be the better alternative but were unsure, which task to depend on. We tried making target the default but this seemed to cause problems.

@esc
Copy link
Contributor

esc commented Jan 28, 2016

Also, the appveyor stuff isn't our doing.

@karolyi
After fixing the path resolving problem ...
8534dee 
... cram_run_test_from_target can be set True per default
@mriehl
Copy link
Member

mriehl commented Jan 28, 2016

Yes you can ignore the appveyor for now. I have to move the hook to the windows compat branch but haven't gotten around to doinc it just yet.

@esc
Copy link
Contributor

esc commented Jan 29, 2016

We now set cram_run_from_target to True. Can you remind me, what is the task that puts things in the target directory? Is it package? If so, maybe we should depend on that task in the cram plugin, currently it is prepare IIRC?

@esc
Copy link
Contributor

esc commented Jan 29, 2016

Though it seems like verify already does that, so I don't think this change will cause any breakage in existing tools.

@esc
Copy link
Contributor

esc commented Jan 29, 2016

Also, once this is merged, I will update the documentation for the cram plugin in docs.

@karolyi
Copy link
Contributor Author

karolyi commented Jan 29, 2016

👍

@esc esc mentioned this pull request Jan 29, 2016
Merged
@esc
Copy link
Contributor

esc commented Jan 29, 2016

Allright after some internal discussion with @mriehl I'll merge this now and release a new version.

esc added a commit that referenced this pull request Jan 29, 2016
@esc
Merge pull request #318 from karolyi/run_cram_from_target_possibility
152e4ef 
Adding the flag for cram to run tests from the target directory
@esc esc merged commit 152e4ef into pybuilder:master Jan 29, 2016
@esc
Copy link
Contributor

esc commented Jan 29, 2016

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karolyi @esc @mriehl