FileNotFoundError doesn't exist (in python?)#332
FileNotFoundError doesn't exist (in python?)#332arcivanov merged 1 commit intopybuilder:masterfrom esc:fix/generated_setup.py
Conversation
|
This fixed Scout24/afp-cli#57 |
|
This is Python 3 vs Python 2 issue: https://docs.python.org/3/library/exceptions.html - FileNotFoundError very much exists in 3 |
|
This PR would also need to update PyBuilder's own |
|
I have made the damn thing python2 and python3 compatible, ideas for testing anyone? |
|
The basic idea is to alias |
|
@esc can you update the local |
|
@mriehl am on the case |
|
@mriehl done, please merge when green |
| sys.exit(e.returncode) | ||
|
|
||
| try: | ||
| subprocess.check_call(["pyb", "clean", "install_build_dependencies", "package", "-o"]) |
There was a problem hiding this comment.
👎
PyB is not available when building PYB
|
setup.py for PyB assumes that PyB is available, which is not the case. |
|
Okay so solution is to remove the pybuilder installation part? |
|
then we don't need the py2/3 capabilitity for this |
|
Should I just revert the latest commit? |
|
Oh wait no, it needs to check if |
|
Sorry, confused, now back to thinking that the |
|
I just looked at setup.py and it doesn't use FileNotFoundError, so you're right, it doesn't have to be changed at all as it's not affected. |
|
Okay, I have reverted the commit, feel free to merge or ask for rebase. |
|
A rebase would be nice :) @esc |
|
done |
FileNotFoundError doesn't exist (in python?)
3 participants
The setup.py generated is buggy, apparently:
Scout24/afp-cli#57