New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileNotFoundError doesn't exist (in python?) #332

Merged
merged 1 commit into from Mar 10, 2016

Conversation

Projects
None yet
3 participants
@esc
Member

esc commented Feb 11, 2016

The setup.py generated is buggy, apparently:

ImmobilienScout24/afp-cli#57

esc added a commit to esc/afp-cli that referenced this pull request Feb 11, 2016

@esc

This comment has been minimized.

Show comment
Hide comment
@esc
Member

esc commented Feb 11, 2016

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Feb 11, 2016

Contributor

This is Python 3 vs Python 2 issue: https://docs.python.org/3/library/exceptions.html - FileNotFoundError very much exists in 3

Contributor

arcivanov commented Feb 11, 2016

This is Python 3 vs Python 2 issue: https://docs.python.org/3/library/exceptions.html - FileNotFoundError very much exists in 3

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Feb 11, 2016

Contributor

This PR would also need to update PyBuilder's own setup.py in the root of the repo

Contributor

arcivanov commented Feb 11, 2016

This PR would also need to update PyBuilder's own setup.py in the root of the repo

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Feb 18, 2016

Member

I have made the damn thing python2 and python3 compatible, ideas for testing anyone?

Member

esc commented Feb 18, 2016

I have made the damn thing python2 and python3 compatible, ideas for testing anyone?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Feb 18, 2016

Member

The basic idea is to alias FileNotFoundError to OSerror when in python2 and then to check the errno also. I have tried it manually in 2.7 and 3.5 and it appears to be working.

Member

esc commented Feb 18, 2016

The basic idea is to alias FileNotFoundError to OSerror when in python2 and then to check the errno also. I have tried it manually in 2.7 and 3.5 and it appears to be working.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Mar 10, 2016

Member

@esc can you update the local setup.py? I'll merge then. Fix looks good (well not good, but practical)

Member

mriehl commented Mar 10, 2016

@esc can you update the local setup.py? I'll merge then. Fix looks good (well not good, but practical)

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

@mriehl am on the case

Member

esc commented Mar 10, 2016

@mriehl am on the case

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

@mriehl done, please merge when green

Member

esc commented Mar 10, 2016

@mriehl done, please merge when green

Show outdated Hide outdated setup.py
sys.exit(e.returncode)
try:
subprocess.check_call(["pyb", "clean", "install_build_dependencies", "package", "-o"])

This comment has been minimized.

@arcivanov

arcivanov Mar 10, 2016

Contributor

👎
PyB is not available when building PYB

@arcivanov

arcivanov Mar 10, 2016

Contributor

👎
PyB is not available when building PYB

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 10, 2016

Contributor

setup.py for PyB assumes that PyB is available, which is not the case.

Contributor

arcivanov commented Mar 10, 2016

setup.py for PyB assumes that PyB is available, which is not the case.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

Okay so solution is to remove the pybuilder installation part?

Member

esc commented Mar 10, 2016

Okay so solution is to remove the pybuilder installation part?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

then we don't need the py2/3 capabilitity for this setup.py?

Member

esc commented Mar 10, 2016

then we don't need the py2/3 capabilitity for this setup.py?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

Should I just revert the latest commit?

Member

esc commented Mar 10, 2016

Should I just revert the latest commit?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

Oh wait no, it needs to check if build.py is available?

Member

esc commented Mar 10, 2016

Oh wait no, it needs to check if build.py is available?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

Sorry, confused, now back to thinking that the setup.py does not need to be changed.

Member

esc commented Mar 10, 2016

Sorry, confused, now back to thinking that the setup.py does not need to be changed.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 10, 2016

Contributor

I just looked at setup.py and it doesn't use FileNotFoundError, so you're right, it doesn't have to be changed at all as it's not affected.

Contributor

arcivanov commented Mar 10, 2016

I just looked at setup.py and it doesn't use FileNotFoundError, so you're right, it doesn't have to be changed at all as it's not affected.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

Okay, I have reverted the commit, feel free to merge or ask for rebase.

Member

esc commented Mar 10, 2016

Okay, I have reverted the commit, feel free to merge or ask for rebase.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Mar 10, 2016

Contributor

A rebase would be nice :) @esc

Contributor

arcivanov commented Mar 10, 2016

A rebase would be nice :) @esc

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Mar 10, 2016

Member

done

Member

esc commented Mar 10, 2016

done

arcivanov added a commit that referenced this pull request Mar 10, 2016

Merge pull request #332 from esc/fix/generated_setup.py
FileNotFoundError doesn't exist (in python?)

@arcivanov arcivanov merged commit 231f630 into pybuilder:master Mar 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arcivanov arcivanov removed the in progress label Mar 10, 2016

@esc esc deleted the esc:fix/generated_setup.py branch Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment