implement get_git_hash

[esc]

Anyone interested in this? I'd write some unit tests if people would want to use this.

[coveralls]

Coverage decreased (-0.1%) to 72.433% when pulling 0b4b5c1 on esc:vcs_include_git_hash into f691e2a on pybuilder:master.

[esc]

Any thoughts on this, if no-one replies I'll just merge it.

[mriehl]

Apologies for the delay, I was afk at the beach 😎
I'm 👍 on merging. Not sure how useful a unit test would be since there is no logic except calling git.

Would probably be better off with a cram test (call through pybuilder, call through plain git) but honestly that sounds like a lot of work for very simple functionality.

[esc]

Should I document it anywhere?

[arcivanov]

@esc Is there some sort of dynamic signature invocation? You added a method, which isn't called explicitly by anything inside PyB. What am I missing? Are you using this in a plugin?

[esc]

@arcivanov I would propose users to call this function.

[arcivanov]

👍