New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement get_git_hash #363

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
4 participants
@esc
Member

esc commented Jun 10, 2016

Anyone interested in this? I'd write some unit tests if people would want to use this.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage decreased (-0.1%) to 72.433% when pulling 0b4b5c1 on esc:vcs_include_git_hash into f691e2a on pybuilder:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.1%) to 72.433% when pulling 0b4b5c1 on esc:vcs_include_git_hash into f691e2a on pybuilder:master.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jun 13, 2016

Member

Any thoughts on this, if no-one replies I'll just merge it.

Member

esc commented Jun 13, 2016

Any thoughts on this, if no-one replies I'll just merge it.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jun 13, 2016

Member

Apologies for the delay, I was afk at the beach 😎
I'm 👍 on merging. Not sure how useful a unit test would be since there is no logic except calling git.

Would probably be better off with a cram test (call through pybuilder, call through plain git) but honestly that sounds like a lot of work for very simple functionality.

Member

mriehl commented Jun 13, 2016

Apologies for the delay, I was afk at the beach 😎
I'm 👍 on merging. Not sure how useful a unit test would be since there is no logic except calling git.

Would probably be better off with a cram test (call through pybuilder, call through plain git) but honestly that sounds like a lot of work for very simple functionality.

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jun 13, 2016

Member

Should I document it anywhere?

Member

esc commented Jun 13, 2016

Should I document it anywhere?

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Jun 16, 2016

Contributor

@esc Is there some sort of dynamic signature invocation? You added a method, which isn't called explicitly by anything inside PyB. What am I missing? Are you using this in a plugin?

Contributor

arcivanov commented Jun 16, 2016

@esc Is there some sort of dynamic signature invocation? You added a method, which isn't called explicitly by anything inside PyB. What am I missing? Are you using this in a plugin?

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Jun 16, 2016

Member

@arcivanov I would propose users to call this function.

Member

esc commented Jun 16, 2016

@arcivanov I would propose users to call this function.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Jun 16, 2016

Contributor

👍

Contributor

arcivanov commented Jun 16, 2016

👍

@arcivanov arcivanov merged commit b981427 into pybuilder:master Jun 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 72.433%
Details

@arcivanov arcivanov removed the in progress label Jun 16, 2016

@esc esc deleted the esc:vcs_include_git_hash branch Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment