New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_directory fix for manifest and setup.py #367

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
6 participants
@cowst
Contributor

cowst commented Jun 29, 2016

extracted explicit root_path in order to fill manifest and setup.py only with relative paths according to package structure

extracted explicit root_path in order to fill manifest and setup.py o…
…nly with relative paths according to package structure
@cowst

This comment has been minimized.

Show comment
Hide comment
@cowst

cowst Jun 29, 2016

Contributor

see comments on #127 (which is already closed)

Contributor

cowst commented Jun 29, 2016

see comments on #127 (which is already closed)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 29, 2016

Coverage Status

Coverage decreased (-0.02%) to 72.415% when pulling 8c02ea4 on cowst:master into a6bcbd6 on pybuilder:master.

coveralls commented Jun 29, 2016

Coverage Status

Coverage decreased (-0.02%) to 72.415% when pulling 8c02ea4 on cowst:master into a6bcbd6 on pybuilder:master.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Jul 13, 2016

Member

Thank you @cowst , I'm merging this as it looks good. Sorry it took a while.

Member

mriehl commented Jul 13, 2016

Thank you @cowst , I'm merging this as it looks good. Sorry it took a while.

@mriehl mriehl merged commit e52a227 into pybuilder:master Jul 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 72.415%
Details
@ZmeiGorynych

This comment has been minimized.

Show comment
Hide comment
@ZmeiGorynych

ZmeiGorynych Jul 12, 2017

Could someone please post an example, or a link to one, for how this is supposed to work?
I'm using project.include_directory('mosaicsmartdata/configuration', ['*.csv']) in my build.py (where the path is relative to dir_source_main_python), and the files are copied over to target/dist/.../mosaicsmartdata/configuration, but not installed.

MANIFEST.in contains recursive-include mosaicsmartdata/configuration *.csv

Using pybuilder 0.11.10

Thanks a lot!

ZmeiGorynych commented Jul 12, 2017

Could someone please post an example, or a link to one, for how this is supposed to work?
I'm using project.include_directory('mosaicsmartdata/configuration', ['*.csv']) in my build.py (where the path is relative to dir_source_main_python), and the files are copied over to target/dist/.../mosaicsmartdata/configuration, but not installed.

MANIFEST.in contains recursive-include mosaicsmartdata/configuration *.csv

Using pybuilder 0.11.10

Thanks a lot!

@MarvBob

This comment has been minimized.

Show comment
Hide comment
@MarvBob

MarvBob Sep 20, 2017

+1
The directory is included but not installed.

MarvBob commented Sep 20, 2017

+1
The directory is included but not installed.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Sep 23, 2017

Contributor

Install "pybuilder" using "-U -pre" ?

Contributor

arcivanov commented Sep 23, 2017

Install "pybuilder" using "-U -pre" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment