New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage for missing modules should cause a failure #377

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@arcivanov
Contributor

arcivanov commented Aug 7, 2016

fixes #376, connected to #376

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 7, 2016

Coverage Status

Coverage increased (+1.08%) to 71.836% when pulling fe3535e on arcivanov:issue_376 into c37f3ed on pybuilder:master.

coveralls commented Aug 7, 2016

Coverage Status

Coverage increased (+1.08%) to 71.836% when pulling fe3535e on arcivanov:issue_376 into c37f3ed on pybuilder:master.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Aug 8, 2016

Contributor

@mriehl I can't see the build results on Travis. Am I the only one?

Contributor

arcivanov commented Aug 8, 2016

@mriehl I can't see the build results on Travis. Am I the only one?

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Aug 8, 2016

Member

No, I was looking too but the build frame doesn't seem to load.

On 08 Aug 2016, at 15:35, Arcadiy Ivanov notifications@github.com wrote:

@mriehl I can't see the build results on Travis. Am I the only one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Member

mriehl commented Aug 8, 2016

No, I was looking too but the build frame doesn't seem to load.

On 08 Aug 2016, at 15:35, Arcadiy Ivanov notifications@github.com wrote:

@mriehl I can't see the build results on Travis. Am I the only one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Aug 8, 2016

Contributor

@mriehl It's worse than that - they can't detect JS in Chrome, lol.

    <noscript>
      <div style="width: 60%; margin: auto;">
        <img src="https://cdn.travis-ci.org/images/logos/TravisCI-Mascot-1-bc6a3179f3e8e1ab1456634bd55a448a.png" alt="Travis CI mascot" width="200" style="float: left; margin: 1em 3em;">
        <div>
          <h1>Hey there!</h1>
          <p>Looks like you have JavaScript disabled.</p>
          <p>The Travis CI webclient needs JavaScript to work properly.</p>
          <h2>Please enable JavaScript to get the best Travis CI experience.</h2>
          <h3>Thank you!</h3>
        </div>
      </div>
    </noscript>
Contributor

arcivanov commented Aug 8, 2016

@mriehl It's worse than that - they can't detect JS in Chrome, lol.

    <noscript>
      <div style="width: 60%; margin: auto;">
        <img src="https://cdn.travis-ci.org/images/logos/TravisCI-Mascot-1-bc6a3179f3e8e1ab1456634bd55a448a.png" alt="Travis CI mascot" width="200" style="float: left; margin: 1em 3em;">
        <div>
          <h1>Hey there!</h1>
          <p>Looks like you have JavaScript disabled.</p>
          <p>The Travis CI webclient needs JavaScript to work properly.</p>
          <h2>Please enable JavaScript to get the best Travis CI experience.</h2>
          <h3>Thank you!</h3>
        </div>
      </div>
    </noscript>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2016

Coverage Status

Coverage increased (+1.6%) to 72.358% when pulling 1e84db4 on arcivanov:issue_376 into c37f3ed on pybuilder:master.

coveralls commented Aug 10, 2016

Coverage Status

Coverage increased (+1.6%) to 72.358% when pulling 1e84db4 on arcivanov:issue_376 into c37f3ed on pybuilder:master.

@arcivanov arcivanov merged commit c2e649f into pybuilder:master Aug 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.6%) to 72.358%
Details

@arcivanov arcivanov deleted the arcivanov:issue_376 branch Aug 10, 2016

@arcivanov arcivanov removed the in progress label Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment