Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modifying default targets similar to manner of adding them in #412 #438

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Allow modifying default targets similar to manner of adding them in #412 #438

merged 1 commit into from
Dec 16, 2016

Conversation

arcivanov
Copy link
Member

fixes #436

@coveralls
Copy link

coveralls commented Dec 15, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 73.236% when pulling f2145b8 on arcivanov:issue_436 into deb92d4 on pybuilder:master.

@arcivanov arcivanov requested review from esc and mriehl December 15, 2016 21:50
mriehl
mriehl approved these changes Dec 16, 2016
View reviewed changes
Copy link
Member

@mriehl mriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. ^ is fitting given its use in regexes although it will be a problem for zsh users (the ^ token is used to replace tokens in a previous command). But escaping it will always work so now real issue here.

@arcivanov arcivanov merged commit a70e40f into pybuilder:master Dec 16, 2016
@arcivanov arcivanov deleted the issue_436 branch December 16, 2016 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriehl mriehl mriehl approved these changes

@esc esc Awaiting requested review from esc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow modifying default targets similar to manner of adding them in #412
3 participants
@arcivanov @coveralls @mriehl