New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying default targets similar to manner of adding them in #412 #438

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
3 participants
@arcivanov
Contributor

arcivanov commented Dec 15, 2016

fixes #436

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 15, 2016

Coverage Status

Coverage increased (+0.07%) to 73.236% when pulling f2145b8 on arcivanov:issue_436 into deb92d4 on pybuilder:master.

coveralls commented Dec 15, 2016

Coverage Status

Coverage increased (+0.07%) to 73.236% when pulling f2145b8 on arcivanov:issue_436 into deb92d4 on pybuilder:master.

@arcivanov arcivanov requested review from esc and mriehl Dec 15, 2016

@mriehl

mriehl approved these changes Dec 16, 2016

Looking good. ^ is fitting given its use in regexes although it will be a problem for zsh users (the ^ token is used to replace tokens in a previous command). But escaping it will always work so now real issue here.

@arcivanov arcivanov merged commit a70e40f into pybuilder:master Dec 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 73.236%
Details

@arcivanov arcivanov deleted the arcivanov:issue_436 branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment