New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing test coverage on vcs_tests.py #439

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
4 participants
@jima80525

jima80525 commented Dec 16, 2016

Just getting the hang of doing development on this tree. Thought I'd pick a file and finish its test coverage.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 16, 2016

Coverage Status

Coverage decreased (-1.3%) to 71.908% when pulling aa3d75d on jima80525:master into deb92d4 on pybuilder:master.

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-1.3%) to 71.908% when pulling aa3d75d on jima80525:master into deb92d4 on pybuilder:master.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Dec 16, 2016

Contributor

@jima80525 welcome to the joys of supporting Python 2.6 😉

Contributor

arcivanov commented Dec 16, 2016

@jima80525 welcome to the joys of supporting Python 2.6 😉

@jima80525

This comment has been minimized.

Show comment
Hide comment
@jima80525

jima80525 Dec 16, 2016

Looks like I failed to take 2.6 into account. Will fix.

One question (in case anyone reads this). How is it reporting that coverage went down? The only thing I did was add unit tests for uncovered code. Hmmm

jima80525 commented Dec 16, 2016

Looks like I failed to take 2.6 into account. Will fix.

One question (in case anyone reads this). How is it reporting that coverage went down? The only thing I did was add unit tests for uncovered code. Hmmm

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Dec 16, 2016

Contributor

The report is correct. Since Python 2.6 failed its coverage didn't count. Therefore all of the Python 2.6 code branches ended up not covered.

Contributor

arcivanov commented Dec 16, 2016

The report is correct. Since Python 2.6 failed its coverage didn't count. Therefore all of the Python 2.6 code branches ended up not covered.

@jima80525

This comment has been minimized.

Show comment
Hide comment
@jima80525

jima80525 commented Dec 16, 2016

Thanks!

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 17, 2016

Coverage Status

Coverage increased (+0.3%) to 73.506% when pulling 938ee52 on jima80525:master into deb92d4 on pybuilder:master.

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.3%) to 73.506% when pulling 938ee52 on jima80525:master into deb92d4 on pybuilder:master.

@arcivanov arcivanov merged commit 224567f into pybuilder:master Dec 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 73.506%
Details
@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Dec 18, 2016

Contributor

Thanks!

Contributor

arcivanov commented Dec 18, 2016

Thanks!

@esc

This comment has been minimized.

Show comment
Hide comment
@esc

esc Dec 19, 2016

Member

Nice work!

Member

esc commented Dec 19, 2016

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment