Skip to content

Naming inconcistency for number loading #1270

Closed
alex opened this Issue Jul 16, 2014 · 2 comments

3 participants

@alex
Python Cryptographic Authority member
alex commented Jul 16, 2014

The RSA and DSA backend have methods like load_rsa_public_numbers and load_dsa_public_numbers, while the Elliptic Curve backend has elliptic_curve_public_key_from_numbers.

Not sure if it's worth teh deprecation cycles to fix this up, but it's a bit unfortunate.

@reaperhulk
Python Cryptographic Authority member

I think this deserves a deprecation cycle.

@public
Python Cryptographic Authority member
public commented Jul 16, 2014

+1

@reaperhulk reaperhulk added this to the Sixth Release milestone Sep 25, 2014
@reaperhulk reaperhulk added a commit to reaperhulk/cryptography that referenced this issue Sep 25, 2014
@reaperhulk reaperhulk deprecate backend method names for elliptic curve number loading
fixes #1270
1962727
@reaperhulk reaperhulk added a commit to reaperhulk/cryptography that referenced this issue Sep 26, 2014
@reaperhulk reaperhulk deprecate backend method names for elliptic curve number loading
fixes #1270
8a7da9f
@reaperhulk reaperhulk added a commit to reaperhulk/cryptography that referenced this issue Sep 26, 2014
@reaperhulk reaperhulk deprecate backend method names for elliptic curve number loading
fixes #1270
4ad5a39
@reaperhulk reaperhulk added a commit to reaperhulk/cryptography that referenced this issue Sep 27, 2014
@reaperhulk reaperhulk deprecate backend method names for elliptic curve number loading
fixes #1270
77e95a0
@alex alex closed this in #1348 Sep 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.