LibreSSL added ALPN support in 2.1.3 #1849
Conversation
This fixes build issues on FreeBSD
|
ok to test |
|
@Sp1l could you give a bit more detail on this? Why does this fix a problem? LibreSSL declares both OPENSSL_VERSION_NUMBER and LIBRESSL_VERSION_NUMBER as 0x20000000L, so what's the scenario where OPENSSL_VERSION_NUMBER is < 0x10002001L but LIBRESSL_VERSION_NUMBER is defined? |
|
@reaperhulk The maintainer of the port decided to modify the OPENSSL_VERSION_NUMBER to 0x1000107fL in the port to make more ports compile without errors https://svnweb.freebsd.org/ports/head/security/libressl/files/patch-include-openssl-opensslv.h?revision=381701&view=markup |
|
I'm extremely conflicted here. Having a distribution make a change like this is a very, very bad thing to do and I don't want to encourage it (even though this is almost certainly what LibreSSL should have done). I guess we'll merge this, but since we don't directly test it this will continue to be problematic for the FreeBSD port. |
LibreSSL added ALPN support in 2.1.3
- Update to 0.8.2 - Update COMMENT (upstream) - Pet portlint (TEST_DEPENDS must appear earlier) - Remove patches that have been upstreamed - Backport ALPN patch merged upstream, not yet released [1] Changes: * https://github.com/pyca/cryptography/blob/0.8.2/CHANGELOG.rst [1] pyca/cryptography#1849 PR: 197049 Submitted by: Bernard Spil <spil.oss gmail com> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@384640 35697150-7ecd-e111-bb59-0022644237b5
- Update to 0.8.2 - Update COMMENT (upstream) - Pet portlint (TEST_DEPENDS must appear earlier) - Remove patches that have been upstreamed - Backport ALPN patch merged upstream, not yet released [1] Changes: * https://github.com/pyca/cryptography/blob/0.8.2/CHANGELOG.rst [1] pyca/cryptography#1849 PR: 197049 Submitted by: Bernard Spil <spil.oss gmail com>
This fixes build issues on FreeBSD