-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed25519 support #4114
ed25519 support #4114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add wycheproof integration to this, and we should have a follow up bug to add support to the ssh key loader.
b000e74
to
b03f144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add testvectors/eddsa_test.json
from wycheproof to this.
also merge conflicts |
Tests will fail due to an OpenSSL wycheproof issue (openssl/openssl#7693). We'll have to decide what to do about that since presumably we're likely to release before OpenSSL patches this. |
Hi, just wanted to leave a note to say thanks for working on this and we're following the progress here so we can enable people to use ed25519 keys in OpenStack Nova (https://bugs.launchpad.net/nova/+bug/1555521). Cheers :) |
Thanks for the link @melwitt. After this lands we'll need to update our openssh public key parser to also support ed25519 and we're not currently tracking that as an issue. Would you mind opening a new one and referencing this pull request as a dependency? That way we can make sure it doesn't get lost. |
2e716e3
to
35f00c0
Compare
old review, things are fixed/changed
Sigh, CI is going to fail on the sid builder until OpenSSL 1.1.1b lands. I don't think that's a reasonable thing to hold this PR on though, so maybe temporarily disable that builder in jenkins? idk |
Blocked on OpenSSL 1.1.1b release.
Fixes #3509