Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed25519 support #4114

Merged
merged 2 commits into from
Feb 27, 2019
Merged

ed25519 support #4114

merged 2 commits into from
Feb 27, 2019

Conversation

reaperhulk
Copy link
Member

@reaperhulk reaperhulk commented Feb 22, 2018 •
edited

Blocked on OpenSSL 1.1.1b release.

  • Changelog entry
  • Update versionadded
  • Rebase when ed25519 vectors land

Fixes #3509

@reaperhulk reaperhulk mentioned this pull request Apr 16, 2018
Closed
8 tasks
@reaperhulk reaperhulk mentioned this pull request Sep 26, 2018
Merged
@reaperhulk reaperhulk changed the title [WIP] ed25519 support ed25519 support Sep 29, 2018
alex
alex reviewed Oct 2, 2018
View reviewed changes
docs/hazmat/primitives/asymmetric/ed25519.rst Show resolved Hide resolved
docs/hazmat/primitives/asymmetric/ed25519.rst Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/backend.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/backend.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/backend.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/ed25519.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/primitives/asymmetric/ed25519.py Outdated Show resolved Hide resolved
tests/hazmat/primitives/test_ed25519.py Outdated Show resolved Hide resolved
@cjwatson cjwatson mentioned this pull request Oct 5, 2018
Closed
alex
alex requested changes Oct 21, 2018
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add wycheproof integration to this, and we should have a follow up bug to add support to the ssh key loader.

docs/hazmat/primitives/asymmetric/ed25519.rst Outdated Show resolved Hide resolved
docs/hazmat/primitives/asymmetric/ed25519.rst Show resolved Hide resolved
docs/hazmat/primitives/asymmetric/index.rst Outdated Show resolved Hide resolved
src/_cffi_src/openssl/cryptography.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/backend.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/backend.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/ed25519.py Outdated Show resolved Hide resolved
@eugene-babichenko eugene-babichenko mentioned this pull request Nov 14, 2018
Merged
alex
alex previously requested changes Nov 23, 2018
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add testvectors/eddsa_test.json from wycheproof to this.

docs/hazmat/primitives/asymmetric/ed25519.rst Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/ed25519.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/backends/openssl/ed25519.py Outdated Show resolved Hide resolved
src/cryptography/hazmat/primitives/asymmetric/ed25519.py Outdated Show resolved Hide resolved
@alex
Copy link
Member

alex commented Nov 23, 2018

also merge conflicts

@reaperhulk
Copy link
Member Author

Tests will fail due to an OpenSSL wycheproof issue (openssl/openssl#7693). We'll have to decide what to do about that since presumably we're likely to release before OpenSSL patches this.

@alex alex mentioned this pull request Jan 4, 2019
Closed
14 tasks
@melwitt
Copy link

melwitt commented Jan 4, 2019

Hi, just wanted to leave a note to say thanks for working on this and we're following the progress here so we can enable people to use ed25519 keys in OpenStack Nova (https://bugs.launchpad.net/nova/+bug/1555521). Cheers :)

@reaperhulk
Copy link
Member Author

Thanks for the link @melwitt. After this lands we'll need to update our openssh public key parser to also support ed25519 and we're not currently tracking that as an issue. Would you mind opening a new one and referencing this pull request as a dependency? That way we can make sure it doesn't get lost.

@melwitt melwitt mentioned this pull request Jan 4, 2019
Closed
@reaperhulk reaperhulk added this to the Twenty Sixth Release milestone Jan 22, 2019
@reaperhulk reaperhulk mentioned this pull request Feb 20, 2019
Closed
@reaperhulk reaperhulk dismissed alex’s stale review February 22, 2019 00:18

old review, things are fixed/changed

@reaperhulk
Copy link
Member Author

Sigh, CI is going to fail on the sid builder until OpenSSL 1.1.1b lands. I don't think that's a reasonable thing to hold this PR on though, so maybe temporarily disable that builder in jenkins? idk

@alex alex merged commit cd05e2a into pyca:master Feb 27, 2019
@reaperhulk reaperhulk deleted the ed25519 branch February 27, 2019 04:34
@paulhovey paulhovey mentioned this pull request Jul 26, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjwatson cjwatson cjwatson left review comments

@alex alex alex approved these changes

Assignees
No one assigned
Labels
primitives
Milestone
Twenty Sixth Release
Development

Successfully merging this pull request may close these issues.

ED25519 Support
4 participants
@reaperhulk @alex @melwitt @cjwatson