Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build with LibreSSL 2.7 #4169

Closed
wants to merge 7 commits into from
Closed

Unbreak build with LibreSSL 2.7 #4169

wants to merge 7 commits into from

Conversation

@Sp1l
Copy link
Contributor

Sp1l commented Mar 25, 2018

LibreSSL added (most of) the OpenSSL 1.1 API. Checks should now
verify OpenSSL < 1.1 && LibreSSL < 2.7

Fixes #4168

Signed-off-by: Bernard Spil brnrd@FreeBSD.org
From: http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/security/py-cryptography/patches/
Author: sthen@OpenBSD.org

Sp1l and others added 7 commits Apr 17, 2016
Update with latest from upstream
* fix a regression in int_from_bytes

* add a new test file
LibreSSL added (most of) the OpenSSL 1.1 API. Checks should now
verify OpenSSL < 1.1 && LibreSSL < 2.7

Signed-off-by: Bernard Spil <brnrd@FreeBSD.org>
@alex

This comment has been minimized.

Copy link
Member

alex commented Mar 25, 2018

Looks like there are still a few errors that need to be resolved here.

Can you please also add 2.7.1 to the Jenkinsfile so we're testing this.

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Mar 25, 2018

(Reminder that modifications to the jenkinsfile will not be honored for non-committers)

@alex

This comment has been minimized.

Copy link
Member

alex commented Mar 25, 2018

Sp1l added a commit to HardenedBSD/hardenedbsd-ports that referenced this pull request Apr 9, 2018
 - LibreSSL 2.7 implements OpenSSL 1.1 API

See also: https://bugs.freebsd.org/226906
Upstream: pyca/cryptography#4169
Signed-off-by: Bernard Spil <bernard.spil@hardenedbsd.org>
@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Apr 11, 2018

This patch breaks most of CI still -- looks like it doesn't properly handle versions != 1.1.0

@Sp1l

This comment has been minimized.

Copy link
Contributor Author

Sp1l commented Apr 29, 2018

This patch is no good indeed @reaperhulk only works with LibreSSL then. Have another one lined up, let me close this and create a new one without the extra commits...

@Sp1l Sp1l closed this Apr 29, 2018
@Sp1l Sp1l reopened this Apr 29, 2018
@Sp1l Sp1l closed this Apr 29, 2018
@gessel

This comment has been minimized.

Copy link

gessel commented Jun 23, 2018

@Sp1l , can you link to your new patch so we can follow the progress?

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Jun 23, 2018

Libre 2.7.x support is already landed in master, it just hasn't been released.

@gessel

This comment has been minimized.

Copy link

gessel commented Jul 4, 2018

@reaperhulk , is there an ETA to release?

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Jul 4, 2018

No, but we should probably set one... @alex what do you think about 2.3 next week?

@gessel

This comment has been minimized.

Copy link

gessel commented Jul 11, 2018

@reaperhulk: update on track?

@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Jul 12, 2018

@gessel We've closed out most of our blockers for 2.3 but still have a few things left. You can see progress here: https://github.com/pyca/cryptography/milestone/25

@gessel

This comment has been minimized.

Copy link

gessel commented Jul 27, 2018

Excellent. Looks like this was closed out 8 days ago, but hasn't hit ports yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.