Fixed #4380 -- do not assume TLSv1 is available in OpenSSL #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallelujah! It's starting to become the case that some OpenSSLs are disabling it.
|
Yes, the change fixes the problem, but for a different reason. Fedora 29 has started to use more aggressive crypto policies. Also please check the error stack. In my case, |
|
Green tests and landing is blocked on #4388 |
|
|
reaperhulk
approved these changes
Aug 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallelujah! It's starting to become the case that some OpenSSLs are disabling it.
@tiran Can you please verify this fixes the tests?