Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunking didn't actually work #5499

Merged
merged 1 commit into from Oct 25, 2020
Merged

chunking didn't actually work #5499

merged 1 commit into from Oct 25, 2020

Conversation

@reaperhulk
Copy link
Member

@reaperhulk reaperhulk commented Oct 25, 2020

We now reach into the bowels of our ciphercontext to make sure the max chunk size doesn't itself cause an OverflowError.

@alex it does not escape me that if we had directly tested this without monkeypatching (as you wanted) we wouldn't have had this bug. But it still takes 4GB of RAM to test this directly and that's too much. 馃槶

@alex
alex approved these changes Oct 25, 2020
@alex alex merged commit 836a92a into pyca:master Oct 25, 2020
20 checks passed
20 checks passed
Python 2.7 on macOS
Details
Python 3.5 on macOS
Details
Python 3.9 on macOS
Details
Python 2.7 on win32
Details
Python 3.5 on win32
Details
Python 3.6 on win32
Details
Python 3.7 on win32
Details
Python 3.8 on win32
Details
Python 3.9 on win32 Python 3.9 on win32
Details
Python 2.7 on win64
Details
Python 3.5 on win64
Details
Python 3.6 on win64
Details
Python 3.7 on win64
Details
Python 3.8 on win64
Details
Python 3.9 on win64 Python 3.9 on win64
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (target 100.00%)
Details
docs/readthedocs.org:cryptography Read the Docs build succeeded!
Details
pyca/check Summary
Details
@reaperhulk reaperhulk deleted the reaperhulk:oops branch Oct 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants