Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move blinding to __init__ on both RSA public and private #5506

Merged
merged 2 commits into from Oct 26, 2020

Conversation

@reaperhulk
Copy link
Member

@reaperhulk reaperhulk commented Oct 25, 2020

In the past, we activated blinding on private numbers and also on private key -> public key creation. Instead, let's just call it in init of both public and private objects. Blinding is on by default in OpenSSL these days but since we're not sure when that occurred (or if there are paths where it does not get turned on) we've decided to just play it safe.

@alex
alex approved these changes Oct 25, 2020
@alex alex merged commit cf9bd6a into pyca:master Oct 26, 2020
20 checks passed
20 checks passed
Python 2.7 on macOS
Details
Python 3.5 on macOS
Details
Python 3.9 on macOS
Details
Python 2.7 on win32
Details
Python 3.5 on win32
Details
Python 3.6 on win32
Details
Python 3.7 on win32
Details
Python 3.8 on win32
Details
Python 3.9 on win32 Python 3.9 on win32
Details
Python 2.7 on win64
Details
Python 3.5 on win64
Details
Python 3.6 on win64
Details
Python 3.7 on win64
Details
Python 3.8 on win64
Details
Python 3.9 on win64 Python 3.9 on win64
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (target 100.00%)
Details
docs/readthedocs.org:cryptography Read the Docs build succeeded!
Details
pyca/check Summary
Details
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants