Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tls bindings for new OpenSSL APIs #5595

Merged
merged 1 commit into from Dec 1, 2020
Merged

Conversation

@alex
Copy link
Member

@alex alex commented Dec 1, 2020

fixes #5379
closes #5483

@alex alex force-pushed the tls-bindings branch 3 times, most recently from fd3e6c0 to ffc4f9b Dec 1, 2020
@alex alex force-pushed the tls-bindings branch from ffc4f9b to 12da376 Dec 1, 2020
@alex alex added this to the Thirty Third Release milestone Dec 1, 2020
@reaperhulk reaperhulk merged commit a209669 into pyca:master Dec 1, 2020
53 checks passed
Loading
@alex alex deleted the tls-bindings branch Dec 1, 2020
@th3b0x
Copy link

@th3b0x th3b0x commented Dec 2, 2020

@reaperhulk @alex I had this marked as draft due to a lack of suitable tests for the cryptography_has_get_proto_version related interfaces (per the user contribution guidelines in the documentation)

I'm not positive how you guys handle this, but is there any intention to add tests for this?

Loading

@alex
Copy link
Member Author

@alex alex commented Dec 2, 2020

No, we don't generally add tests for bindings.

Loading

@th3b0x
Copy link

@th3b0x th3b0x commented Dec 2, 2020

ah. That would have simplified things greatly. Good to know.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants