Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add Cryptography_HAS_TLSEXT_HOSTNAME and bump for 3.3.1 #5625

Merged
merged 2 commits into from Dec 10, 2020

Conversation

@reaperhulk
Copy link
Member

@reaperhulk reaperhulk commented Dec 9, 2020

No description provided.

CHANGELOG.rst Outdated
@@ -1,13 +1,18 @@
Changelog
=========

.. _v3-3-1:

3.3 - 2020-12-09
Copy link
Member

@alex alex Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Loading

Copy link
Member Author

@reaperhulk reaperhulk Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Loading

// This symbol is being preserved because removing it will break users with
// pyOpenSSL < 19.1 and pip < 20.x. We need to leave this in place until those
// users have upgraded.
static const long Cryptography_HAS_TLSEXT_HOSTNAME = 1;
Copy link
Member

@alex alex Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one of our deprecation symbols here in a comment, so we remember to grep for it?

Loading

alex
alex approved these changes Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants