Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a hubot docker image #42

Merged
merged 6 commits into from
Apr 27, 2017
Merged

add a hubot docker image #42

merged 6 commits into from
Apr 27, 2017

Conversation

reaperhulk
Copy link
Member

This requires a token passed as an environment variable to work properly. We'll need to figure out how we want to provide that.

@reaperhulk
Copy link
Member Author

This is now r4r. Tested by adding HUBOT_GITHUB_TOKEN via docker secret create and then doing docker service create --name="hubot" --secret="HUBOT_GITHUB_TOKEN" pyca/hubot. The latter needs to be added to ansible after this is merged and we need to decide how to document the secret creation requirement...

@@ -0,0 +1 @@
web: bin/hubot -a irc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses this?

@@ -0,0 +1,2 @@
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated by yo script that makes hubot configs, but I don't know if it's actually required (similarly, not sure about procfile). I'll experiment and see quickly.

@alex
Copy link
Member

alex commented Apr 27, 2017

Actually, before we merge this, please create a CREDENTIALS.md with useful information.

@reaperhulk
Copy link
Member Author

Information about what the credentials need to be? Do you want that to live in the hubot dir?

@alex
Copy link
Member

alex commented Apr 27, 2017

No, in teh root of the repo please.

hubot/Dockerfile Outdated

COPY ["data/package.json", "/home/hubot/bot/"]
COPY ["data/scripts/", "/home/hubot/bot/scripts"]
COPY ["data/bin/", "/home/hubot/bot/bin"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines don't need the array syntax, do they? COPY data/bin/ /home/hubot/bot/bin works right?


set -e

npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does running hubot trigger an npm install?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. the yo script that creates a hubot does this. We could potentially remove it.

RUN apt-get install -qq -y runit

ENV HUBOT_IRC_SERVER irc.freenode.net
ENV HUBOT_IRC_ROOMS #cryptography-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not need to be quoted?

Copy link
Member Author

@reaperhulk reaperhulk Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The ENV instruction has two forms. The first form, ENV key value, will set a single variable to a value. The entire string after the first space will be treated as the value - including characters such as spaces and quotes."

@alex alex merged commit 98c8484 into master Apr 27, 2017
@alex alex deleted the hubot branch April 27, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants