-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a hubot docker image #42
Conversation
This is now r4r. Tested by adding |
hubot/data/Procfile
Outdated
@@ -0,0 +1 @@ | |||
web: bin/hubot -a irc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What uses this?
hubot/data/external-scripts.json
Outdated
@@ -0,0 +1,2 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What uses this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated by yo script that makes hubot configs, but I don't know if it's actually required (similarly, not sure about procfile). I'll experiment and see quickly.
Actually, before we merge this, please create a |
Information about what the credentials need to be? Do you want that to live in the hubot dir? |
No, in teh root of the repo please. |
hubot/Dockerfile
Outdated
|
||
COPY ["data/package.json", "/home/hubot/bot/"] | ||
COPY ["data/scripts/", "/home/hubot/bot/scripts"] | ||
COPY ["data/bin/", "/home/hubot/bot/bin"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines don't need the array syntax, do they? COPY data/bin/ /home/hubot/bot/bin
works right?
hubot/data/bin/hubot
Outdated
|
||
set -e | ||
|
||
npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does running hubot
trigger an npm install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. the yo
script that creates a hubot does this. We could potentially remove it.
RUN apt-get install -qq -y runit | ||
|
||
ENV HUBOT_IRC_SERVER irc.freenode.net | ||
ENV HUBOT_IRC_ROOMS #cryptography-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not need to be quoted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The ENV instruction has two forms. The first form, ENV key value, will set a single variable to a value. The entire string after the first space will be treated as the value - including characters such as spaces and quotes."
This requires a token passed as an environment variable to work properly. We'll need to figure out how we want to provide that.