Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some of the techniques from https://caremad.io/2014/11/distribu… … …ting-a-cffi-project/ #115

Merged
merged 4 commits into from Nov 27, 2014

Conversation

@NegativeMjark
Copy link
Contributor

NegativeMjark commented Nov 27, 2014

In particular make sure "nacl._lib" is imported after setup has installed the setup_requires. Otherwise trying to pip install pynacl on a fresh system which doesn't have cffi installed will silently fail because it won't have built the cffi extension module.

…ting-a-cffi-project/ in the hope of making 'pip install' work reliably for pynacl
… do not as 'use_system' is called for all of them
@reaperhulk

This comment has been minimized.

Copy link
Member

reaperhulk commented Nov 27, 2014

Thanks for the contribution!

@dstufft it's only appropriate that you review fixes inspired by your own post 😄

dstufft added a commit that referenced this pull request Nov 27, 2014
Apply some of the techniques from https://caremad.io/2014/11/distribu… … …ting-a-cffi-project/
@dstufft dstufft merged commit d4d3175 into pyca:master Nov 27, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.