Apply some of the techniques from https://caremad.io/2014/11/distribu… … …ting-a-cffi-project/#115
Merged
dstufft merged 4 commits intopyca:masterfrom Nov 27, 2014
Merged
Conversation
…ting-a-cffi-project/ in the hope of making 'pip install' work reliably for pynacl
… do not as 'use_system' is called for all of them
Member
|
Thanks for the contribution! @dstufft it's only appropriate that you review fixes inspired by your own post 😄 |
dstufft
added a commit
that referenced
this pull request
Nov 27, 2014
Apply some of the techniques from https://caremad.io/2014/11/distribu… … …ting-a-cffi-project/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular make sure "nacl._lib" is imported after setup has installed the setup_requires. Otherwise trying to pip install pynacl on a fresh system which doesn't have cffi installed will silently fail because it won't have built the cffi extension module.