Sort input file list #609
Closed
Sort input file list #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding a comment that mentions why it's being sorted? I'd like to minimize the chance we regress on this in the future. Once the comment is there this lgtm. |
|
added the comment. Sorry for missing your note. |
|
Unfortunately we've switched to |
so that nacl/_sodium.abi3.so builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good. This PR was done while working on reproducible builds for openSUSE.
|
rebased without conflicts |
reaperhulk
approved these changes
Aug 10, 2020
|
black still thinks it would reformat this file so CI is still failing |
|
Happy to merge a PR like this if someone wants to take it over |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sort input file list
so that
nacl/_sodium.abi3.sobuilds in a reproducible wayin spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.
This PR was done while working on reproducible builds for openSUSE.