Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Run tests against Python 3.4 #87

Merged
merged 1 commit into from Jul 14, 2014

Conversation

Projects
None yet
4 participants
Owner

alex commented Jul 13, 2014

No description provided.

Coverage Status

Coverage decreased (-0.05%) when pulling 026f208 on alex:py34 into 20bb77b on pyca:master.

Owner

alex commented Jul 13, 2014

I don't understand how this could lower coverage.

Contributor

warner commented Jul 14, 2014

It looks like py26/py27 has 85.71% coverage, pypy has 85.93% but py32/33/34 has 85.27%, and now there's more py3x jobs to lower the average? So the new total is 2_.8571+3_.8593+1_.8527, vs the old total of 2_.8571+2_.8593+1_.8527 ?

Owner

alex commented Jul 14, 2014

Oh, uh, I guess that makes sense, I didn't realize that's how coveralls did
it, I assume it just took the intersection of uncovered lines.

On Sun, Jul 13, 2014 at 10:34 PM, Brian Warner notifications@github.com
wrote:

It looks like py26/py27 has 85.71% coverage, pypy has 85.93% but
py32/33/34 has 85.27%, and now there's more py3x jobs to lower the average?
So the new total is 2_.8571+3_.8593+1_.8527, vs the old total of
2_.8571+2_.8593+1_.8527 ?


Reply to this email directly or view it on GitHub
#87 (comment).

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

Contributor

Ayrx commented Jul 14, 2014

That's like... totally stupid, heh. This LGTM. 👍

@warner warner pushed a commit that referenced this pull request Jul 14, 2014

Brian Warner Merge pull request #87 from alex/py34
Run tests against Python 3.4
e97d00d

@warner warner merged commit e97d00d into pyca:master Jul 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@alex alex deleted the alex:py34 branch Jul 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment