Merged
Conversation
tjni
changed the title
Member
Contributor
Author
|
Thank you! I like your approach better than mine. I'll rebase on top of that commit for the time being so that CI can run. |
mhils
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_set_keylog_callback(and a couple others) are consistently failing for me locally on my M1 Mac. I don't know exactly why this happens, but I hypothesize it's related to the non-blocking nature of the handshake and perhaps delays in my system while the handshake is taking place. By adding aselectcall to block whenWantReadErroris raised, I'm able to get these tests to pass on my machine.In addition, I noticed
pytestwarning me that the sockets created in the_handshake_testmethod were not closed, so I'm wrapping the body of the method now in awithblock.