Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't randomly fail with KeyError in shutdown(). #225

Merged
merged 5 commits into from
Apr 14, 2015
Merged

Don't randomly fail with KeyError in shutdown(). #225

merged 5 commits into from
Apr 14, 2015

Conversation

glyph
Copy link
Contributor

@glyph glyph commented Apr 14, 2015

Fixes #224

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 3afdba8 on glyph:right-error into 468bd42 on pyca:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 3afdba8 on glyph:right-error into 468bd42 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 3afdba8 on glyph:right-error into 468bd42 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 3afdba8 on glyph:right-error into 468bd42 on pyca:master.

@hynek
Copy link
Contributor

hynek commented Apr 14, 2015

Bots are happy; please add a changelog entry and we’ll release 0.15.1 ASAP.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.72%) to 92.49% when pulling 5457bad on glyph:right-error into 468bd42 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.36%) to 92.85% when pulling 5457bad on glyph:right-error into 468bd42 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 5457bad on glyph:right-error into 468bd42 on pyca:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.22% when pulling 5457bad on glyph:right-error into 468bd42 on pyca:master.

hynek added a commit that referenced this pull request Apr 14, 2015
@hynek
Merge pull request #225 from glyph/right-error
bdcfced 
Don't randomly fail with KeyError in shutdown().
@hynek hynek merged commit bdcfced into pyca:master Apr 14, 2015
@glyph glyph mentioned this pull request Apr 14, 2015
Open
@hynek hynek mentioned this pull request Apr 14, 2015
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.15 raises a KeyError on calling shutdown twice
3 participants
@glyph @coveralls @hynek