Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup meta data, use README as long_description #248

Merged
merged 2 commits into from May 5, 2015
Merged

Dedup meta data, use README as long_description #248

merged 2 commits into from May 5, 2015

Conversation

hynek
Copy link
Contributor

@hynek hynek commented Apr 30, 2015

I’ve moved all the relevant meta data into OpenSSL/version.py (and init.py; basically cryptography-style) and extract it from there in setup.py and the Sphinx conf.py.

Fixes #247

Opinions?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.31% when pulling 7ddc4ff on hynek:dedup into f3fc99e on pyca:master.

@reaperhulk
Copy link
Member

This mostly LGTM. Any reason you chose to use regexes rather than the exec() approach cryptography uses?

@hynek
Copy link
Contributor Author

hynek commented May 3, 2015

Hm it all started from the code you find in doc/conf.py and I’ve expanded it for all kinds of meta information. Do you find the exec way superior?

@reaperhulk
Copy link
Member

I don't have a preference on exec, just curious. This needs a rebase now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.31% when pulling 5bc17cb on hynek:dedup into 8b71990 on pyca:master.

@hynek
Copy link
Contributor Author

hynek commented May 5, 2015

Rebased and Travis is through.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 95.31% when pulling 6d212a4 on hynek:dedup into 8b71990 on pyca:master.

reaperhulk added a commit that referenced this pull request May 5, 2015
Dedup meta data, use README as long_description
@reaperhulk reaperhulk merged commit 44b305e into pyca:master May 5, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Dedup meta information
3 participants