Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented state_string function #358

Merged
merged 6 commits into from Sep 8, 2015
Merged

Implemented state_string function #358

merged 6 commits into from Sep 8, 2015

Conversation

@kjav
Copy link
Contributor

@kjav kjav commented Sep 7, 2015

No description provided.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 7, 2015

Current coverage is 93.11%

Merging #358 into master will increase coverage by +0.05% as of 6ec2e4d

@@            master    #358   diff @@
======================================
  Files           14      14       
  Stmts         5322    5347    +25
  Branches       459     461     +2
  Methods          0       0       
======================================
+ Hit           4953    4979    +26
+ Partial        145     144     -1
  Missed         224     224       

Review entire Coverage Diff as of 6ec2e4d

Powered by Codecov. Updated on successful CI builds.

@kjav
Copy link
Contributor Author

@kjav kjav commented Sep 7, 2015

This is the last function in the Connection class that is not yet implemented. There are still functions in the Context class which are not implemented, but do not throw NotImplemented exceptions (e.g. load_client_ca)

@alex
Copy link
Member

@alex alex commented Sep 7, 2015

Looks ok to me, @hynek can you confirm?

@hynek
Copy link
Contributor

@hynek hynek commented Sep 7, 2015

Needs a changelog entry, otherwise seems ok.

@kjav
Copy link
Contributor Author

@kjav kjav commented Sep 7, 2015

Is the format of that entry ok?

ChangeLog Outdated
2015-09-07 Sam Lee <sam.rr.lee@gmail.com>

* OpenSSL/SSL.py, OpenSSL/test/test_ssl.py: Implemented
the empty ``Connection.state_string()`` function, using

This comment has been minimized.

@alex

alex Sep 7, 2015
Member

Can you remove the word "empty", I think it's confusing unless you know the full history of this bug.

@kjav
Copy link
Contributor Author

@kjav kjav commented Sep 8, 2015

OK, that makes sense. I have removed it.

hynek added a commit that referenced this pull request Sep 8, 2015
Implemented state_string function
@hynek hynek merged commit c5c569a into pyca:master Sep 8, 2015
2 checks passed
2 checks passed
codecov/commit 100.00% (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek
Copy link
Contributor

@hynek hynek commented Sep 8, 2015

thanks!

@kjav kjav deleted the kjav:patch-3 branch Sep 8, 2015
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Apr 20, 2016
Changes:
16.0.0 (2016-03-19)
-------------------
This is the first release under full stewardship of PyCA.
We have made *many* changes to make local development more pleasing.
The test suite now passes both on Linux and OS X with OpenSSL 0.9.8,
1.0.1, and 1.0.2.  It has been moved to `py.test <https://pytest.org/>`_,
all CI test runs are part of `tox <https://testrun.org/tox/>`_ and
the source code has been made fully `flake8
<https://flake8.readthedocs.org/>`_ compliant.

We hope to have lowered the barrier for contributions significantly
but are open to hear about any remaining frustrations.

Backward-incompatible changes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- Python 3.2 support has been dropped.
  It never had significant real world usage and has been dropped
  by our main dependency ``cryptography``.  Affected users should
  upgrade to Python 3.3 or later.

Deprecations:
^^^^^^^^^^^^^
- The support for EGD has been removed.
  The only affected function ``OpenSSL.rand.egd()`` now uses
  ``os.urandom()`` to seed the internal PRNG instead.  Please see
  `pyca/cryptography#1636
  <https://github.com/pyca/cryptography/pull/1636>`_ for more
  background information on this decision.  In accordance with our
  backward compatibility policy ``OpenSSL.rand.egd()`` will be
  *removed* no sooner than a year from the release of 16.0.0.
  Please note that you should `use urandom
  <http://sockpuppet.org/blog/2014/02/25/safely-generate-random-numbers/>`_
  for all your secure random number needs.
- Python 2.6 support has been deprecated.
  Our main dependency ``cryptography`` deprecated 2.6 in version
  0.9 (2015-05-14) with no time table for actually dropping it.
  pyOpenSSL will drop Python 2.6 support once ``cryptography``
  does.

Changes:
^^^^^^^^
- Fixed ``OpenSSL.SSL.Context.set_session_id``,
  ``OpenSSL.SSL.Connection.renegotiate``,
  ``OpenSSL.SSL.Connection.renegotiate_pending``, and
  ``OpenSSL.SSL.Context.load_client_ca``.
  They were lacking an implementation since 0.14.  `#422
  <https://github.com/pyca/pyopenssl/pull/422>`_
- Fixed segmentation fault when using keys larger than 4096-bit to sign data.
  `#428 <https://github.com/pyca/pyopenssl/pull/428>`_
- Fixed ``AttributeError`` when ``OpenSSL.SSL.Connection.get_app_data()``
  was called before setting any app data.
  `#304 <https://github.com/pyca/pyopenssl/pull/304>`_
- Added ``OpenSSL.crypto.dump_publickey()`` to dump ``OpenSSL.crypto.PKey``
  objects that represent public keys, and ``OpenSSL.crypto.load_publickey()``
  to load such objects from serialized representations.
  `#382 <https://github.com/pyca/pyopenssl/pull/382>`_
- Added ``OpenSSL.crypto.dump_crl()`` to dump a certificate revocation
  list out to a string buffer.
  `#368 <https://github.com/pyca/pyopenssl/pull/368>`_
- Added ``OpenSSL.SSL.Connection.get_state_string()`` using the
  OpenSSL binding ``state_string_long``.
  `#358 <https://github.com/pyca/pyopenssl/pull/358>`_
- Added support for the ``socket.MSG_PEEK`` flag to
  ``OpenSSL.SSL.Connection.recv()`` and
  ``OpenSSL.SSL.Connection.recv_into()``.
  `#294 <https://github.com/pyca/pyopenssl/pull/294>`_
- Added ``OpenSSL.SSL.Connection.get_protocol_version()`` and
  ``OpenSSL.SSL.Connection.get_protocol_version_name()``.
  `#244 <https://github.com/pyca/pyopenssl/pull/244>`_
- Switched to ``utf8string`` mask by default.
  OpenSSL formerly defaulted to a ``T61String`` if there were UTF-8
  characters present.  This was changed to default to ``UTF8String``
  in the config around 2005, but the actual code didn't change it
  until late last year.  This will default us to the setting that
  actually works.  To revert this you can call
  ``OpenSSL.crypto._lib.ASN1_STRING_set_default_mask_asc(b"default")``.
  `#234 <https://github.com/pyca/pyopenssl/pull/234>`_
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.