New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should consider actually testing Twisted. #579

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
4 participants
@Lukasa
Member

Lukasa commented Nov 28, 2016

Currently we're not actually running any Twisted tests: see this build. This patch actually runs them.

@hawkowl

This comment has been minimized.

Show comment
Hide comment
@hawkowl

hawkowl Nov 28, 2016

Member

lol the py35 tests failed because of a timestamp

Member

hawkowl commented Nov 28, 2016

lol the py35 tests failed because of a timestamp

@hynek

This comment has been minimized.

Show comment
Hide comment
@hynek

hynek Nov 28, 2016

Contributor

yeah that’s my favorite race condition. one day i’ll fix it and save 93758903427589043h of restarting jobs all the time.

Contributor

hynek commented Nov 28, 2016

yeah that’s my favorite race condition. one day i’ll fix it and save 93758903427589043h of restarting jobs all the time.

@reaperhulk reaperhulk merged commit f189de9 into pyca:master Nov 28, 2016

3 checks passed

codecov/patch Coverage not affected when comparing e15e60a...702c1d7
Details
codecov/project 95.65% (+0.00%) compared to e15e60a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Lukasa added a commit to Lukasa/pyopenssl that referenced this pull request Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment