Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the deprecated rand.egd function #630

Merged
merged 6 commits into from May 31, 2017
Merged

Drop the deprecated rand.egd function #630

merged 6 commits into from May 31, 2017

Conversation

@alex
Copy link
Member

@alex alex commented May 31, 2017

No description provided.

alex added 5 commits May 31, 2017
@codecov
Copy link

@codecov codecov bot commented May 31, 2017

Codecov Report

Merging #630 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   96.79%   96.78%   -0.01%     
==========================================
  Files          18       18              
  Lines        5642     5625      -17     
  Branches      393      390       -3     
==========================================
- Hits         5461     5444      -17     
  Misses        121      121              
  Partials       60       60
Impacted Files Coverage Δ
src/OpenSSL/rand.py 91.3% <ø> (-1.8%) ⬇️
tests/test_rand.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52975c...267528a. Read the comment docs.

@hynek
hynek approved these changes May 31, 2017
Copy link
Contributor

@hynek hynek left a comment

lgtm, covfefe only went down because we removed covered code.

@hynek hynek merged commit 3ed6273 into master May 31, 2017
3 of 4 checks passed
3 of 4 checks passed
codecov/project 96.78% (-0.01%) compared to d52975c
Details
codecov/patch Coverage not affected when comparing d52975c...267528a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hynek hynek deleted the alex-patch-2 branch May 31, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants