New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated md5 default on CRL.export() #652

Merged
merged 6 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@alex
Member

alex commented Jun 30, 2017

No description provided.

@Lukasa

LGTM, we can merge when green.

Doh

@alex alex dismissed stale reviews from hynek and Lukasa via 7dfbd24 Jun 30, 2017

@codecov

This comment has been minimized.

codecov bot commented Jun 30, 2017

Codecov Report

Merging #652 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   96.95%   96.94%   -0.01%     
==========================================
  Files          18       18              
  Lines        5740     5734       -6     
  Branches      401      401              
==========================================
- Hits         5565     5559       -6     
  Misses        117      117              
  Partials       58       58
Impacted Files Coverage Δ
src/OpenSSL/crypto.py 96.8% <100%> (-0.01%) ⬇️
tests/test_crypto.py 98.61% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f903...d996411. Read the comment docs.

alex added some commits Jun 30, 2017

@codecov

This comment has been minimized.

codecov bot commented Jun 30, 2017

Codecov Report

Merging #652 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   96.95%   96.94%   -0.01%     
==========================================
  Files          18       18              
  Lines        5740     5734       -6     
  Branches      401      401              
==========================================
- Hits         5565     5559       -6     
  Misses        117      117              
  Partials       58       58
Impacted Files Coverage Δ
src/OpenSSL/crypto.py 96.8% <100%> (-0.01%) ⬇️
tests/test_crypto.py 98.61% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f903...d996411. Read the comment docs.

@Lukasa

Lukasa approved these changes Jun 30, 2017

@Lukasa Lukasa merged commit 173e4ba into pyca:master Jun 30, 2017

3 checks passed

codecov/patch 100% of diff hit (target 96.95%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.04% compared to 941f903
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alex alex deleted the alex:remove-md5 branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment