Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix #664 #665
referenced this pull request
Jul 19, 2017
Tests didn't catch this because to have it take the fallback path we fetched the values from cffi and then monkeypatched our constants (https://github.com/pyca/pyopenssl/blob/master/tests/test_ssl.py#L1114-L1142). So the comparison succeed since they were both bytes.
I think a better fix here is just to declare these as byte strings and not unicode. They're not really paths to us, just sentinel values.
@@ Coverage Diff @@ ## master #665 +/- ## ======================================= Coverage 96.94% 96.94% ======================================= Files 18 18 Lines 5737 5737 Branches 401 401 ======================================= Hits 5562 5562 Misses 117 117 Partials 58 58