Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define __all__ to make wildcard import work #719

merged 1 commit into from Nov 26, 2017

define __all__ to make wildcard import work #719

merged 1 commit into from Nov 26, 2017


Copy link

@nikaro nikaro commented Nov 22, 2017

Fix #715

Elements are classified in the order in which they are defined.

Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #719 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
+ Coverage   97.03%   97.03%   +<.01%     
  Files          18       18              
  Lines        5667     5669       +2     
  Branches      394      394              
+ Hits         5499     5501       +2     
  Misses        112      112              
  Partials       56       56
Impacted Files Coverage Δ
src/OpenSSL/ 96.86% <100%> (ø) ⬆️
src/OpenSSL/ 94.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57051a5...94ac10a. Read the comment docs.

Copy link

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disapprove of what this change leverages but I guess it’s good form.

@hynek hynek merged commit 736c621 into pyca:master Nov 26, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

PKey not imported with from […] import *
2 participants